Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Serialization of decimal.Decimal values in JSON fields is failing for SQL targets #1897

Closed
1 task done
edgarrmondragon opened this issue Aug 7, 2023 · 0 comments · Fixed by #1898
Closed
1 task done

bug: Serialization of decimal.Decimal values in JSON fields is failing for SQL targets #1897

edgarrmondragon opened this issue Aug 7, 2023 · 0 comments · Fixed by #1898
Assignees
@edgarrmondragon
Labels
kind/Bug Something isn't working regression valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.30.0

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Taps (catalog, state, etc.)

Operating System

NA

Description

SQL targets are failing to serialize values of type decimal.Decimal in JSON fields after we started deserializing JSON numeric values to that type in #1809.

This can be easily fixed by using a custom json_serializer (and json_deserializer, for good measure) on the engine created for the SQL connector instance.

Code

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarrmondragon edgarrmondragon

Labels
kind/Bug Something isn't working regression valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(targets): Correctly serialize decimal.Decimal in JSON fields of SQL targets meltano/sdk
1 participant
@edgarrmondragon