Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow allowed_values and examples in any JSON schema type constructor #1603

Merged
merged 7 commits into from
Apr 13, 2023
Merged

feat: Allow allowed_values and examples in any JSON schema type constructor #1603

merged 7 commits into from
Apr 13, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 12, 2023 •
edited
Loading

@edgarrmondragon edgarrmondragon mentioned this pull request Apr 12, 2023
Closed
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #1603 (a678984) into main (fae094e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   86.18%   86.25%   +0.06%     
==========================================
  Files          58       58              
  Lines        4750     4771      +21     
  Branches      798      801       +3     
==========================================
+ Hits         4094     4115      +21     
  Misses        465      465              
  Partials      191      191
Impacted Files Coverage Δ
singer_sdk/typing.py 95.34% <100.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 12, 2023 01:09
@TyShkan TyShkan mentioned this pull request Apr 12, 2023
Closed
TyShkan
TyShkan reviewed Apr 12, 2023
View reviewed changes
singer_sdk/typing.py Outdated Show resolved Hide resolved
@aaronsteers aaronsteers linked an issue Apr 12, 2023 that may be closed by this pull request
feat: extend allowed_values option of JSONSchema for Property(ArrayType) #1600
Closed
@WillDaSilva WillDaSilva requested a review from TyShkan April 12, 2023 21:32
@edgarrmondragon edgarrmondragon merged commit ae0a624 into main Apr 13, 2023
@edgarrmondragon edgarrmondragon deleted the 1600-array-values-enum branch April 13, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillDaSilva WillDaSilva WillDaSilva approved these changes

@TyShkan TyShkan TyShkan approved these changes

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

@aaronsteers aaronsteers Awaiting requested review from aaronsteers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: extend allowed_values option of JSONSchema for Property(ArrayType)
3 participants
@edgarrmondragon @TyShkan @WillDaSilva