Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Remove debugging and samples extras (they were never really available to users) #1467

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Feb 28, 2023

Closes #1465


📚 Documentation preview 📚: https://meltano-sdk--1467.org.readthedocs.build/en/1467/

@edgarrmondragon edgarrmondragon linked an issue Feb 28, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1467 (61d6bc0) into main (b30a713) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          57       57           
  Lines        4760     4760           
  Branches      813      813           
=======================================
  Hits         4070     4070           
  Misses        498      498           
  Partials      192      192           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch 4 times, most recently from c895567 to d44c544 Compare February 28, 2023 19:44
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 28, 2023 19:52
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) February 28, 2023 19:53
@edgarrmondragon edgarrmondragon force-pushed the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch from d44c544 to bd75dae Compare March 1, 2023 04:14
@edgarrmondragon edgarrmondragon changed the title fix(deps): Move pyarrow and viztracer extras to main dependencies fix(deps): Remove debugging and samples extras (they were never really available to users) Mar 1, 2023
@edgarrmondragon edgarrmondragon force-pushed the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch 3 times, most recently from e746a26 to 78a195c Compare March 7, 2023 17:34
@edgarrmondragon edgarrmondragon force-pushed the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch from 78a195c to 4d7f426 Compare March 7, 2023 17:37
pyproject.toml Outdated Show resolved Hide resolved
@edgarrmondragon edgarrmondragon force-pushed the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch from 6f74055 to cb404d0 Compare March 8, 2023 00:49
@WillDaSilva WillDaSilva self-requested a review March 8, 2023 01:20
@edgarrmondragon edgarrmondragon merged commit 170275b into main Mar 8, 2023
@edgarrmondragon edgarrmondragon deleted the 1465-bug-package-extras-in-pyprojecttoml-are-not-valid branch March 8, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Package extras in pyproject.toml are not valid
2 participants