Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: SQLTarget - Record missing key property should fail nicely #1147

Closed
visch opened this issue Nov 5, 2022 · 0 comments · Fixed by #1769
Closed

[Feature]: SQLTarget - Record missing key property should fail nicely #1147

visch opened this issue Nov 5, 2022 · 0 comments · Fixed by #1769
Assignees
Labels
kind/Feature New feature or request valuestream/SDK

Comments

@visch
Copy link
Contributor

visch commented Nov 5, 2022

Feature scope

Targets (data type handling, batching, SQL object generation, etc.)

Description

Should go on SQL Target milestone

https://github.com/MeltanoLabs/target-postgres/blob/4f677d3f30ceaf8415dd1a401d22ab8aaf06e2a2/target_postgres/tests/test_standard_target.py#L172 is the test

We should fail nicely, this test was taken from https://github.com/MeltanoLabs/target-sqlite/blob/master/tests/test_target_sqlite.py#L44

We should probably do the validation in the SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Feature New feature or request valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants