Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add explanation and recommendations for context usage #1060

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 10, 2022

From the conversation in #1028 and other conversations in Slack regarding manually adding properties to the context object, it's probably not too clear what can and can't be done with the object at this point.

In the long term we may want to enforce the latter by making the context immutable during stream sync.


📚 Documentation preview 📚: https://meltano-sdk--1060.org.readthedocs.build/en/1060/

@edgarrmondragon edgarrmondragon requested review from a team as code owners October 10, 2022 23:43
@edgarrmondragon edgarrmondragon marked this pull request as draft October 10, 2022 23:43
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (b9f693b) to head (f87ac25).
Report is 1078 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          39       39           
  Lines        3747     3747           
  Branches      628      628           
=======================================
  Hits         3115     3115           
  Misses        470      470           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 11, 2022 15:42
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) October 15, 2022 01:28
@edgarrmondragon edgarrmondragon merged commit c859845 into main Oct 15, 2022
@edgarrmondragon edgarrmondragon deleted the docs-context-object branch October 15, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants