diff --git a/components/lib/dialog/Dialog.js b/components/lib/dialog/Dialog.js index 9b22c407a0..9e27e43a00 100644 --- a/components/lib/dialog/Dialog.js +++ b/components/lib/dialog/Dialog.js @@ -2,6 +2,7 @@ import * as React from 'react'; import PrimeReact, { PrimeReactContext, localeOption } from '../api/Api'; import { useHandleStyle } from '../componentbase/ComponentBase'; import { CSSTransition } from '../csstransition/CSSTransition'; +import FocusTrap from '../focustrap/FocusTrap'; import { ESC_KEY_HANDLING_PRIORITIES, useDisplayOrder, useEventListener, useGlobalOnEscapeKey, useMergeProps, useMountEffect, useUnmountEffect, useUpdateEffect } from '../hooks/Hooks'; import { TimesIcon } from '../icons/times'; import { WindowMaximizeIcon } from '../icons/windowmaximize'; @@ -60,7 +61,6 @@ export const Dialog = React.forwardRef((inProps, ref) => { priority: [ESC_KEY_HANDLING_PRIORITIES.DIALOG, displayOrder] }); - const [bindDocumentKeyDownListener, unbindDocumentKeyDownListener] = useEventListener({ type: 'keydown', listener: (event) => onKeyDown(event) }); const [bindDocumentResizeListener, unbindDocumentResizeListener] = useEventListener({ type: 'mousemove', target: () => window.document, listener: (event) => onResize(event) }); const [bindDocumentResizeEndListener, unbindDocumentResizEndListener] = useEventListener({ type: 'mouseup', target: () => window.document, listener: (event) => onResizeEnd(event) }); const [bindDocumentDragListener, unbindDocumentDragListener] = useEventListener({ type: 'mousemove', target: () => window.document, listener: (event) => onDrag(event) }); @@ -107,49 +107,6 @@ export const Dialog = React.forwardRef((inProps, ref) => { event.preventDefault(); }; - const onKeyDown = (event) => { - const currentTarget = event.currentTarget; - - if (!currentTarget || !currentTarget.primeDialogParams) { - return; - } - - const params = currentTarget.primeDialogParams; - const paramLength = params.length; - const dialogId = params[paramLength - 1] ? params[paramLength - 1].id : undefined; - - if (dialogId !== idState) { - return; - } - - const dialog = document.getElementById(dialogId); - - if (event.key === 'Tab') { - event.preventDefault(); - const focusableElements = DomHandler.getFocusableElements(dialog); - - if (focusableElements && focusableElements.length > 0) { - if (!document.activeElement) { - focusableElements[0].focus(); - } else { - const focusedIndex = focusableElements.indexOf(document.activeElement); - - if (event.shiftKey) { - if (focusedIndex === -1 || focusedIndex === 0) { - focusableElements[focusableElements.length - 1].focus(); - } else { - focusableElements[focusedIndex - 1].focus(); - } - } else if (focusedIndex === -1 || focusedIndex === focusableElements.length - 1) { - focusableElements[0].focus(); - } else { - focusableElements[focusedIndex + 1].focus(); - } - } - } - } - }; - const onDragStart = (event) => { if (DomHandler.hasClass(event.target, 'p-dialog-header-icon') || DomHandler.hasClass(event.target.parentElement, 'p-dialog-header-icon')) { return; @@ -374,8 +331,6 @@ export const Dialog = React.forwardRef((inProps, ref) => { bindDocumentResizeListener(); bindDocumentResizeEndListener(); } - - bindDocumentKeyDownListener(); }; const unbindGlobalListeners = () => { @@ -383,7 +338,6 @@ export const Dialog = React.forwardRef((inProps, ref) => { unbindDocumentDragEndListener(); unbindDocumentResizeListener(); unbindDocumentResizEndListener(); - unbindDocumentKeyDownListener(); }; const createStyle = () => { @@ -653,7 +607,7 @@ export const Dialog = React.forwardRef((inProps, ref) => { return undefined; }; - const createTemplateElement = ({ maskProps, rootProps, transitionProps }) => { + const createTemplateElement = () => { const messageProps = { header: props.header, content: props.message, @@ -662,32 +616,22 @@ export const Dialog = React.forwardRef((inProps, ref) => { const templateElementProps = { headerRef, contentRef, footerRef, closeRef, hide: onClose, message: messageProps }; - return ( -
- -
{ObjectUtils.getJSXElement(inProps.content, templateElementProps)}
-
-
- ); + return ObjectUtils.getJSXElement(inProps.content, templateElementProps); }; - const createElement = ({ maskProps, rootProps, transitionProps }) => { + const createElement = () => { const header = createHeader(); const content = createContent(); const footer = createFooter(); const resizer = createResizer(); return ( -
- -
- {header} - {content} - {footer} - {resizer} -
-
-
+ <> + {header} + {content} + {footer} + {resizer} + ); }; @@ -742,15 +686,25 @@ export const Dialog = React.forwardRef((inProps, ref) => { ptm('transition') ); - if (inProps?.content) { - const templateElement = createTemplateElement({ maskProps, rootProps, transitionProps }); + let contentElement = null; - return ; + if (inProps?.content) { + contentElement = createTemplateElement(); + } else { + contentElement = createElement(); } - const element = createElement({ maskProps, rootProps, transitionProps }); + const rootElement = ( +
+ +
+ {contentElement} +
+
+
+ ); - return ; + return ; }; return maskVisibleState && createDialog();