-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple small items not scrolling with momentum on iOS [Needs Fixing on latest version 3.8.4] #614
Comments
Hi @summerkiflain, You should take a look at #189, as well as this note from the doc. Note that a prop |
@bd-arc I have read the #189, there is no solution to the problem which I mentioned and shown in the expo example, note from the doc doesn't mention plugin not working correctly on iOS, its mostly about android and flatlist's underlying problems. I am already using |
@summerkiflain Well, I don't understand what's going on with your own example. Here's a quick one I made: https://snack.expo.io/BJKN_2coB As you can see, everything is working as intended. Two other things to note:
|
@bd-arc Thanks for the helpful expo snack, I can confirm that snap-carousel is working fine for above issue pre v3.8.0, I have reverted my dependency to v3.7.5 and its working fine, but there is a bug where |
This is an awesome package, really is! But it seems like momentum isn't even working on iPhone, just put the first example on the example folder to work, added |
@JoaoPedroRodrigues for now just revert your |
I tried reverting, even in version 3.7.5 it doesn't seem to work. |
@JoaoPedroRodrigues checkout the https://snack.expo.io/BJKN_2coB (posted by |
@summerkiflain I tried that snack out, my case is not with small sized items tho, not sure if that's what is making it behave differently. I haven't created an expo snack yet because I'm basically running the first example on the example folder. Thank you for your help tho! |
@bd-arc Any update on this, this is not resolved on the latest version |
Thanks @summerkiflain, that's useful! I assume the culprit is this. Two different features seem to contradict themselves here: autoplay & momentum. I won't be able to look into it further for the time being, but if you want to investigate that'll be appreciated ;-) |
Hi @bd-arc, I really don't use autoplay feature at-all, I'll think about fixing the code for users who don't use autoplay and create a new PR. will see what can be done for users using autoplay feature later. |
Have you managed to get it working? I ran into same issue, that with 3.8.4 enableMomentum is not working and I cannot go onto older version since then having some other initial item doesn't work properly 😕 |
Couldn't get around to fix it for PR, I just change the line |
Is this a bug report, a feature request, or a question?
Yes, A Bug report.
Have you followed the required steps before opening a bug report?
There is this one ticket that could be closely related: Choppy behaviour on iOS when slide's width is small #51, but in the lower posts op has described it different then my scenario, he is trying to use it with some map component. P.S it is closed due to no further feedback.
Have you made sure that it wasn't a React Native bug?
Not sure.
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Only happening on iOS, working fine on Android, tested on simulator and physical devices.
Is the bug reproductible in a production environment (not a debug one)?
Yes happening in production env also.
Environment
I have been using expo environment to develop, its on the latest expo version sdk 35, and i have tested with the latest snap carousel version. react and react native versions are latest that are supported by the expo sdk.
Environment:
React: 16.8.3
React native: https://github.com/expo/react-native/archive/sdk-35.0.0.tar.gz
react-native-snap-carousel: 3.8.3
Target Platform:
iOS (12.4.2)
Expected Behavior
Scrolling multiple item should be smooth like the android system.
Actual Behavior
Scrolling multiple small items horizontally with momentum is only scrolling 1 item, sometimes it looks like that its going to scroll multiple items but then it either doesn't snap to the center of the carousel or just returns back to the last item which was next to the previously centered item.
Reproducible Demo
https://snack.expo.io/@summersyed/snap-carousel-momentum-scroll-bug
Steps to Reproduce
although bug is apparent on the iOS simulator provided with expo, you can check it out more clearly on an actual iOS physical device, I have tested it on iPhone 6 and iPhone X, both are not able to scroll multiple items on dev and prod version of the app.
The text was updated successfully, but these errors were encountered: