Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<img> tags do not render their image content on 6.0.0-alpha.12 #460

Closed
5 tasks done
dstaley opened this issue Feb 8, 2021 · 2 comments
Closed
5 tasks done

<img> tags do not render their image content on 6.0.0-alpha.12 #460

dstaley opened this issue Feb 8, 2021 · 2 comments
Labels
bug:upstream The bug is caused by a third party library. bug Crush'em all.

Comments

@dstaley
Copy link

dstaley commented Feb 8, 2021

Oath

I swear that I have completed these tasks before submitting:

Decision table

  • My issue does not look like “The HTML attribute 'xxx' is ignored” (unless
    we claim support for it),
  • My issue does not look like “The HTML element <yyy> is not rendered”

Bug Report

The content of images is not rendered. A View is created for them (including a border and alt text if provided), but the actual image content is not rendered.

Setup

Devices

  • Samsung Galaxy S21
    • OS: Android 11
    • Diagnostic:
    • Environment: development

Reproduction

Description
  1. Render HTML containing an <img> tag with a valid src attribute

Expected result: Image is rendered
Actual result: An empty box is rendered

Reproducible Demo

Snack

Additional Notes

This issue does not occur using v6.0.0-alpha.11, only 6.0.0-alpha.12.

@dstaley dstaley added the bug Crush'em all. label Feb 8, 2021
@jsamr jsamr added the bug:upstream The bug is caused by a third party library. label Feb 8, 2021
@jsamr
Copy link
Collaborator

jsamr commented Feb 8, 2021

@dstaley I've marked this bug as upstream because alpha.12 is using the URL constructor described by the WHATWG standard, which react-native JavaScript engine doesn't follow closely, see facebook/react-native#30914. This is why the bug does not occur on react-native-web.

I'm going to publish a patch today, probably depending on a more reliable third-party.

jsamr added a commit that referenced this issue Feb 8, 2021
A react-native bug adds an extraneous slash to URL.href, causing some
resources such as images to misload.

fix #460
@jsamr
Copy link
Collaborator

jsamr commented Feb 8, 2021

@dstaley This issue has been fixed in version 6.0.0-alpha.13. See full changelog here: https://github.com/meliorence/react-native-render-html/releases/tag/v6.0.0-alpha.13

Thanks a lot for your report!

@jsamr jsamr closed this as completed Feb 8, 2021
jsamr added a commit that referenced this issue Jun 4, 2021
A react-native bug adds an extraneous slash to URL.href, causing some
resources such as images to misload.

fix #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:upstream The bug is caused by a third party library. bug Crush'em all.
Projects
None yet
Development

No branches or pull requests

2 participants