From 9552fc620455f8ca2c4f2b734a2f19473c85b4c9 Mon Sep 17 00:00:00 2001 From: Jasper Craeghs Date: Wed, 12 Apr 2023 16:05:57 +0200 Subject: [PATCH 1/3] Support the new 'Dependent' Jira link --- src/mlx/jira_juggler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mlx/jira_juggler.py b/src/mlx/jira_juggler.py index 85b9618..46f050b 100644 --- a/src/mlx/jira_juggler.py +++ b/src/mlx/jira_juggler.py @@ -355,7 +355,7 @@ def load_from_jira_issue(self, jira_issue): for link in jira_issue.fields.issuelinks: if hasattr(link, 'inwardIssue') and link.type.name == 'Blocker': self.append_value(to_identifier(link.inwardIssue.key)) - if hasattr(link, 'outwardIssue') and link.type.name == 'Dependency': + if hasattr(link, 'outwardIssue') and link.type.name in ('Dependency', 'Dependent'): self.append_value(to_identifier(link.outwardIssue.key)) def validate(self, task, tasks): From 04a9c1b9efe6e322d3bd60e354f59e37331a8c71 Mon Sep 17 00:00:00 2001 From: Jasper Craeghs Date: Wed, 12 Apr 2023 16:35:44 +0200 Subject: [PATCH 2/3] Update GitHub actions and use codecov/codecov-action@v3 --- .github/workflows/python-package.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index b89dc1f..371ffe7 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -11,9 +11,9 @@ jobs: matrix: python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} - name: Install dependencies @@ -22,9 +22,15 @@ jobs: python -m pip install tox tox-gh-actions - name: Run test run: tox -e py - - name: Codecov + - name: Upload coverage to Codecov if: matrix.python-version == 3.9 - run: tox -e codecov + uses: codecov/codecov-action@v3 + with: + token: ${{ secrets.CODECOV_TOKEN }} + files: ./coverage.xml + fail_ci_if_error: true + flags: unittests + verbose: true - name: Static checks if: matrix.python-version == 3.9 run: tox -e check @@ -35,9 +41,9 @@ jobs: needs: test runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: '3.7' - name: Install dependencies From b5ef7c7e6b47672b9cd787e7b1a1c6a2e8af37ea Mon Sep 17 00:00:00 2001 From: Jasper Craeghs Date: Wed, 12 Apr 2023 16:36:17 +0200 Subject: [PATCH 3/3] Remove rule for removed codecov Python package --- tox.ini | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tox.ini b/tox.ini index dc38ebe..8fb6d67 100644 --- a/tox.ini +++ b/tox.ini @@ -21,7 +21,7 @@ basepython = py39: {env:TOXPYTHON:python3.9} py310: {env:TOXPYTHON:python3.10} py311: {env:TOXPYTHON:python3.11} - {clean,check,report,coveralls,codecov}: python3 + {clean,check,report,coveralls}: python3 setenv = PYTHONPATH={toxinidir}/tests PYTHONUNBUFFERED=yes @@ -35,7 +35,7 @@ deps = pip>=20.3.4 parameterized commands = - {posargs:py.test --cov --cov-report=term-missing -vv tests} + pytest --cov-report=term-missing --cov-report=xml -vv --cov tests [testenv:check] deps = @@ -58,15 +58,6 @@ skip_install = true commands = coveralls [] -[testenv:codecov] -deps = - codecov -skip_install = true -commands = - coverage xml --ignore-errors - codecov [] - - [testenv:report] deps = coverage skip_install = true