Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Click on calendar event should open editable detailed view of event #1

Closed
sberger opened this issue Sep 24, 2024 · 9 comments · Fixed by #62
Closed

Calendar: Click on calendar event should open editable detailed view of event #1

sberger opened this issue Sep 24, 2024 · 9 comments · Fixed by #62
Assignees
Labels
Improvement Not a new function, but an improvement of something that exists (UX, design, code, performance)

Comments

@sberger
Copy link
Collaborator

sberger commented Sep 24, 2024

  • As service staff I want to be able to edit booking requests
  • After booking parties have sent a request
  • So that missing information can be added or mistakes corrected

When an event has been approved by the service team, it appears in the calendar. After the event has been approved, it can't be edited by the booking person.

When the booking person clicks on the event slot, a detailed view (read only) of the event opens. Editing is not possible for the booking person.

When the service team clicks on the event slot, a detailed view (reading and editing permitted) of the event opens.

Open detailed view ("Termin öffnen")

@sberger sberger added good first issue Good for new coders/ collaborators Improvement Not a new function, but an improvement of something that exists (UX, design, code, performance) labels Sep 24, 2024
@sberger sberger changed the title Termin soll mit dem Formular verknüpft sein, um ihn bearbeiten zu können Detailansicht Termin Sep 30, 2024
@pdorok pdorok changed the title Detailansicht Termin Detailed view: Event Sep 30, 2024
@melanietreitinger melanietreitinger changed the title Detailed view: Event Click on calendar event should open editable detailed view of event Oct 7, 2024
@melanietreitinger melanietreitinger removed the good first issue Good for new coders/ collaborators label Oct 8, 2024
@melanietreitinger melanietreitinger removed their assignment Oct 8, 2024
@melanietreitinger melanietreitinger closed this as completed by moving to In progress DEV in BookIt Planning Board Oct 9, 2024
@melanietreitinger
Copy link
Owner

melanietreitinger commented Oct 17, 2024

Role See all details of event Edit all details of event
Service-Team
Booking person only own events / = usermodified
Examiner only assigned events / = personinchargeid, otherexaminers
Others no details

@melanietreitinger melanietreitinger self-assigned this Oct 17, 2024
@pdorok pdorok changed the title Click on calendar event should open editable detailed view of event Calendar: Click on calendar event should open editable detailed view of event Oct 21, 2024
@melanietreitinger
Copy link
Owner

Es wird zwischen folgenden Akteuren unterschieden:

function database column
Buchende Person usermodified (current userid)
Prüfungsverantwortliche Person personinchargeid
Weitere Prüfende otherexaminers

Umsetzung:
-> User-Suchfelder, keine Freitextfelder (alle beteiligten Personen müssen einen Moodle Account haben)
-> berechtigt für Detailansicht

Nachteilsausgleich bleibt in Formular:

  • Checkbox: Zeitverlängerung
  • Texteingabefeld: Sonstiger NTA

Note

Action db fields
Remove from db personinchargename, personinchargeemail
New in db otherexaminers (list of userids), timecompensation (yes/no)
Rename status in bookingstatus

@melanietreitinger
Copy link
Owner

melanietreitinger commented Oct 24, 2024

Todo:

  • Get username from userid for personinchargeid and otherexaminers
  • Add field coursetemplate

Resources:

  • Save room
  • Save other resources

Form: add fields for service team:

  • bookingstatus
  • internalnotes
  • supportpersons
  • refcourseid (?)

Capabilities:

  • make internal fields only visible & editable for service team

@sberger sberger changed the title Calendar: Click on calendar event should open editable detailed view of event Click on calendar event should open editable detailed view of event Oct 25, 2024
@pdorok pdorok changed the title Click on calendar event should open editable detailed view of event Calendar: Click on calendar event should open editable detailed view of event Oct 28, 2024
@melanietreitinger
Copy link
Owner

melanietreitinger commented Nov 6, 2024

Moving this issue so that it can be tested.

Use branch "1-click-on-calendar-event-should-open-editable-detailed-view-of-event" to test!

Will be continued in #55

@sberger sberger moved this from Ready to FUNKTEST to In Progress FUNKTEST in BookIt Planning Board Dec 2, 2024
@sberger sberger moved this from In Progress FUNKTEST to Ready to FUNKTEST in BookIt Planning Board Dec 2, 2024
@DeniseMaterna DeniseMaterna moved this from Ready to FUNKTEST to In Progress FUNKTEST in BookIt Planning Board Dec 4, 2024
@melanietreitinger melanietreitinger moved this from In Progress FUNKTEST to In progress DEV in BookIt Planning Board Dec 9, 2024
@melanietreitinger melanietreitinger moved this from In progress DEV to Ready to FUNKTEST in BookIt Planning Board Dec 11, 2024
@melanietreitinger
Copy link
Owner

Role See all details of event Edit all details of event
Service-Team ✅ ✅
Booking person only own events / = usermodified ❌
Examiner only assigned events / = personinchargeid, otherexaminers ❌
Others no details ❌

✔ This should work now!

✔ Code on test server has been updated.

Note

The role "bookingperson" needs the capability moodle/course:enrolreview (already added in the xml file in sciebo).

@AndreasErbe94
Copy link

Only Service-Team and Admin can see events. Examiner and Booking person coldn't see any events, no matter if the account crate the event or was added later. (tested with the account emily)
Giving the capability "mod/bookit:viewalldetailsofownevent" does not change anything, therefore reversed.

@AndreasErbe94 AndreasErbe94 moved this from Ready to FUNKTEST to In Progress FUNKTEST in BookIt Planning Board Dec 18, 2024
@melanietreitinger
Copy link
Owner

There was an sql error which is now fixed (in branch 55-calendar-add-capabilities-to-booking-request-form).

However, the capability "mod/bookit:viewalldetailsofownevent" is needed for Examiner and Booking Person, so I have re-added it to these roles.

@DeniseMaterna
Copy link
Collaborator

Funkt-Test:

  • Rights to view are correct for every role.
  • Rights to edit are corret for: service-team, observer
  • Other Examiner or Person in charge can edit the event.

@DeniseMaterna DeniseMaterna moved this from In Progress FUNKTEST to Ready to DEV in BookIt Planning Board Jan 9, 2025
@melanietreitinger melanietreitinger moved this from Ready to DEV to In progress DEV in BookIt Planning Board Jan 13, 2025
@melanietreitinger
Copy link
Owner

Capabilities should be fixed now - please continue this in Issue #55!

@melanietreitinger melanietreitinger moved this from In progress DEV to Ready to FUNKTEST in BookIt Planning Board Jan 16, 2025
@DeniseMaterna DeniseMaterna moved this from Ready to FUNKTEST to Ready for REVIEW and RELTEST in BookIt Planning Board Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Ready for REVIEW and RELTEST to CLOSED in BookIt Planning Board Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Not a new function, but an improvement of something that exists (UX, design, code, performance)
Projects
Status: CLOSED
Development

Successfully merging a pull request may close this issue.

4 participants