Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Correct Node Clamp Issue? #192

Open
AtomicPerception opened this issue Aug 7, 2024 · 2 comments
Open

Color Correct Node Clamp Issue? #192

AtomicPerception opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels
type: 🐛 bug Something isn't working

Comments

@AtomicPerception
Copy link

Describe the bug

I just noticed that a recent change to the CPU version of the color correct node causes it to perform slightly different. Last week, I set the offset to 0.8 to lift dark area in my z-depth image to a brighter level. Today, I noticed that is no longer working. However, if I set clamp to false on the CPU version, it works as it used to.
When I try the same thing using the GPU version, I don't have to set clamp to false.
I'm not sure if both nodes are supposed to perform the same, but there appears to be a discrepancy between them as far as raising the offset value with clamp true.
Untitled-1

Reproduction

No response

Expected behavior

No response

Operating System

Windows (Default)

Comfy Mode

Comfy Portable (embed) (Default)

Console output

No response

Additional context

No response

@AtomicPerception AtomicPerception added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Aug 7, 2024
@melMass melMass removed the status: 🧹 needs triage This issue needs to triage, applied to new issues label Aug 8, 2024
@melMass
Copy link
Owner

melMass commented Aug 8, 2024

Thanks for the report I will check today more precisely

@micwalk
Copy link

micwalk commented Sep 10, 2024

I have also experienced a similar issue where the normal color correct node does nothing if clamp=true but works when clamp=false. Color correct gpu works either way. I took a brief look at the code and have no idea why this could be happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants