Disambiguate some SaveHandler names. #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to go ahead and guess that said compiler is eclipse? (I am not opposed to changing it if so, just want to know a concrete example of what compiler you were having issues with it for) |
thiakil
approved these changes
Jan 25, 2025
|
It's actually VS Code's Java plugin, OpenJDK 21 may be coming into play sideways. Builds still work, but the lexical-only syntax checked gets cranky when it can't resolve the implied inner-class ... name collision that still works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to in 577523a, there are some ambiguous inner-class names that cause some compilers to whine/choke.