Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update playground #1820

Closed
Strift opened this issue Jan 5, 2025 · 4 comments · Fixed by #1821
Closed

Update playground #1820

Strift opened this issue Jan 5, 2025 · 4 comments · Fixed by #1821
Labels
enhancement New feature or request good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@Strift
Copy link
Collaborator

Strift commented Jan 5, 2025

Description
Running yarn install on the playground project results in issues with node-gyp, that might deter newcomers from testing the app.

It's also using quite an old stack (parcel v1), it could be worth updating it to use something more modern, like Vite

Expected behavior
You would expect the installation to be successful.

Environment (please complete the following information):

  • OS: MacOS 14.7.2
  • Node versions: 16.20.2, 18.20.5, or 20.17.0
@Strift Strift added enhancement New feature or request good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) labels Jan 5, 2025
@flevi29
Copy link
Collaborator

flevi29 commented Jan 5, 2025

#1740 (comment)

@Strift Strift mentioned this issue Jan 5, 2025
Merged
3 tasks
@Strift
Copy link
Collaborator Author

Strift commented Jan 5, 2025

Yeah, I'm actually currently reviewing PR #1740 and can't even get the playground to install lol.

@flevi29
Copy link
Collaborator

flevi29 commented Jan 5, 2025

Yeah, sorry about that, I only really made sure that the tests run. I too planned to make this PR, although a bit differently. Multiple yarn installs aren't ideal. The whole tests/env is not ideal. But for now I wanted to improve as much as I can the base project before getting to those.

@meili-bors meili-bors bot closed this as completed in 7032370 Jan 5, 2025
@flevi29
Copy link
Collaborator

flevi29 commented Jan 5, 2025

Oh, it seems there is a playground of sorts in tests/env too, which is confusing.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Playground] Replace Parcel by Vite meilisearch/meilisearch-js
2 participants
@Strift @flevi29