-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid running integration tests for pre-release PRs #309
Comments
Hello @Strift Hum, I have difficulty to fully agree on this one. Seeing if the tests are failing with the current stable release is a way to see potential errors that are not necessarily expected and that could help during pre-release These situations (tests failing with the current stable release) are not supposed to happen often. Indeed, once the vector store will be stabilized, the "breaking" changes we have are kind of rare. We had one with the highlight recently, but I have to say this is the first one in more than a year that is not related to vector store. So, for me, we should keep these tests, and not remove them from running on If we see we have way more often breaking changes than I said, this could be something to reconsider. But I would love to know the @brunoocasali opinion on it as well! PS: Since this problem is not only a problem on meilisearch-js, and could happen in every SDK, you can open it on integration guide instead, so I move it 😉 |
Description
The GitHub integration currently includes two workflows:
latest
Docker tag)meilisearch:v1.x.y.rc-z
Docker tag)The Integration Tests often fail on
bump-*
branches because these branches include updates that depend on the target version (the new release), which isn’t yet compatible with the stable version used in these tests.Proposed Solution
Update the CI configuration to ensure that only Pre-release Integration Tests are executed for bump-* branches. This adjustment will align the tests with the appropriate Meilisearch version and prevent unnecessary failures.
The text was updated successfully, but these errors were encountered: