Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: possible memory leak when multiple UIcreature, UIitem are displayed in UIScrollArea ? #889

Closed
2 of 5 tasks
kokekanon opened this issue Sep 23, 2024 · 3 comments
Closed
2 of 5 tasks
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@kokekanon
Copy link
Collaborator

kokekanon commented Sep 23, 2024

the memory increase is exponential in the case of UIcreature , UI item in a UIscrollArea.

if it is a UIwidget the memory increase is marginal.

.
.
.
.

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

1) v8

500mb -> 549 mb

v8.mp4

.
.
.
.

.

2) redemption

200mb -> 670 mb

game_outfit

Secuencia.02.mp4

150mb -> 800 mb

game_store

Secuencia.02_1.mp4

150mb -> 460 mb

game_cyclopedia

Secuencia.02_2.mp4

if I add all three and walk around the map for a while it is very easy to get to ~1gb ram in less than 1 minute.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kokekanon kokekanon added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 23, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Sep 23, 2024
@kokekanon
Copy link
Collaborator Author

kokekanon commented Sep 23, 2024

module for test https://github.com/user-attachments/files/17100970/game_testPR.zip

force test :

image

2024-09-23.13-14-50.mp4

@mehah
Copy link
Owner

mehah commented Sep 23, 2024

I believe this leak may be pointers stuck in lua,

reduce this time:

constexpr uint32_t LUA_TIME = 15 * 60 * 1000; // 15min

for example 10 seconds, to see if the memory is freed up faster.

and about the memory being at "100mb" then going to "500mb" it is because the assets and texture are lazy loading, in v8 as it is dat/spr, it loads everything 1x to memory.

@kokekanon
Copy link
Collaborator Author

You're right, haha. I got scared when I saw 1.5 GB of ram being used.

I also tried with spr 11.00.

init end
Redemption 11.00 512~520 mb 670~710 mb
otcv8 11.00 513 mb 599 mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants