Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player:getVocation() function does not return all vocation IDs #845

Closed
2 of 5 tasks
BastardofWinterfell opened this issue Aug 13, 2024 · 2 comments
Closed
2 of 5 tasks

player:getVocation() function does not return all vocation IDs #845

BastardofWinterfell opened this issue Aug 13, 2024 · 2 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@BastardofWinterfell
Copy link

BastardofWinterfell commented Aug 13, 2024 •
edited
Loading

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

The player:getVocation() function currently only returns a number from 1 to 4 corresponding to the four basic unpromoted vocations in Tibia.

  1. Knight
  2. Paladin
  3. Sorcerer
  4. Druid

However, it should also return different numbers (e.g. from 11 to 14) to differentiate promoted vocations, which should have different client IDs, from their unpromoted equivalents.

  1. Elite Knight
  2. Royal Paladin
  3. Master Sorcerer
  4. Elder Druid

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@BastardofWinterfell BastardofWinterfell added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 13, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Aug 13, 2024
@kokekanon
Copy link
Collaborator

https://github.com/mehah/otclient/blob/main/modules/gamelib/player.lua#L175

@kokekanon
Copy link
Collaborator

kokekanon commented Nov 28, 2024 •
edited
Loading

changes were incorporated cyclopedia

134c6dc
you can use this function
https://github.com/mehah/otclient/blob/main/modules/gamelib/player.lua#L175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BastardofWinterfell @kokekanon