Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPC store showing only-buyable items in the sell tab with price #1088

Closed
2 of 5 tasks
lucasoares opened this issue Feb 1, 2025 · 3 comments
Closed
2 of 5 tasks

NPC store showing only-buyable items in the sell tab with price #1088

lucasoares opened this issue Feb 1, 2025 · 3 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@lucasoares
Copy link
Contributor

lucasoares commented Feb 1, 2025 •
edited
Loading

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

Items that can only be bought in the NPC appears in the sell tab. The price seems to be set as max 32-bit unsigned integer.

I'm using TFS 0.3x

Buy tab:
Image

Sell tab:
Image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lucasoares lucasoares added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 1, 2025
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Feb 1, 2025
@kokekanon
Copy link
Collaborator

kokekanon commented Feb 1, 2025 •
edited
Loading

your problem is in the server, not in the client

main repo :

Image

solution in tfs

https://github.com/otland/forgottenserver/issues/4292
https://github.com/otland/forgottenserver/pull/4293

Image

@lucasoares lucasoares changed the title NPC store showing items only buyable in the sell tab with price NPC store showing only-buyable items in the sell tab with price Feb 1, 2025
@lucasoares
Copy link
Contributor Author

lucasoares commented Feb 1, 2025 •
edited
Loading

your problem is in the server, not in the client

main repo :

Image Image

solution in tfs

https://github.com/otland/forgottenserver/issues/4292
https://github.com/otland/forgottenserver/pull/4293

Image

That was my first thought too, but on normal tibia client this doesn't happen.. I will investigate it further, thanks.

@lucasoares lucasoares mentioned this issue Feb 1, 2025
Closed
@lucasoares
Copy link
Contributor Author

Fixed with TFS fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasoares @kokekanon