Conversion of React JSX Props on newlines fails

[karlhorky]

JSX props (React) on their own lines do not convert correctly to template strings:

function Div(props) {
  return (
    <div
      {...props}
      prop-on-new-line="abc"
      // comment
      another-on-new-line="def"
    />
  );
}

[karlhorky]

This is a known issue with the extension (see #15 (comment) for background)

[meganrogge]

pushing this change soon after doing some more testing @karlhorky

[karlhorky]

Looks really good for this example @meganrogge , thanks!! 🙌

[karlhorky]

Another unhandled case is returning to the JavaScript rules once inside of JSX opening tags.

Inside of opening tags in JSX, there may be the use of JavaScript expressions (starting with an opening curly bracket and ending with a closing curly). Since we back in regular JavaScript, the special JSX opening tag rules / behavior should not apply.

One common example is usage of a style prop:

<Link
  to="/"
  style={{
    float: 'left',
  }}
>
  ←
</Link>

The result of editing 'left' here is float: {`left${}`}, should be float: `left${}`

---

Another example would be no prop at all, using object spread:

<Link
  {...{
    a: 'b'
  }}
/>

The result of editing 'b' here is a: {`b${}`}, should be a: `b${}`

---

Both of these examples with objects fail when editing values or also any keys which are in the form of strings (eg. editing display here: <Link style={{"display": "block"}} />).

---

Also, an expression as a standalone string (no usage of an object):

<Link
  href={'abc'}
/>

The result of editing 'abc' here is href={{`abc${}`}}, should be href={`abc${}`}

---

This also happens on single lines:

<Link href={'abc'} />

The result of editing 'abc' here is href={{`abc${}`}}, should be href={`abc${}`}

---

Or a different expression (an admittedly unusual pattern):

<Link
  href={href='abc'}
/>

The result of editing 'abc' here is href={href={`abc${}`}}, should be href={href=`abc${}`}

---

All of these fail when adding interpolation in the string.

New issue again?

[meganrogge]

@karlhorky thanks for the examples. reopened this issue and will look into it.

[meganrogge]

@karlhorky after re-reading this, I'm kind of confused. Are you saying in the example you provided it shouldn't convert to a JSX prop, even though it's following an = sign and is within a start and end tag? What is the difference here? Do you have a suggestion for how I can tell if it's within normal JavaScript instead of a JSX prop?

[karlhorky]

Sorry, I have updated the examples above to include what happens now and what should happen.

The main takeaway here can be the following rules:

1. as soon as you hit <\w+\s+ (approximate, incomplete regex) in a JavaScript file, you're inside a JSX opening tag (and the special rules for props in JSX opening tags are activated)
2. as soon as you hit { inside that tag, you are in a JavaScript expression, with normal JavaScript rules (until you hit a < again, recursively - which goes back to 1.)

The 1st rule above is being applied correctly, but the 2nd - going back to JavaScript rules within that opening tag - is not.

In case you're using regex, there are a couple of regular expression implementations for JSX opening tags and JavaScript expression in Prism.js and VS Code that may help:

• https://github.com/PrismJS/prism/blob/25bdb494c147272167d2b31de5a2af104298b354/components/prism-jsx.js
• https://github.com/microsoft/vscode/blob/7d57a8f6f546b5e30027e7cfa87bd834eb5c7bbb/extensions/javascript/syntaxes/JavaScript.tmLanguage.json#L5516-L5628

[meganrogge]

Hoping to get to this soon

[meganrogge]

Having issues publishing the extension atm, but hopefully will be able to do so soon and thus reflect this fix.

[karlhorky]

Great! When there's a new version, I'll test it out :)

[meganrogge]

It has been released so lmk @karlhorky

[karlhorky]

ok trying on v0.5.4 now

[karlhorky]

The result of editing 'left' here is float: {`left${}`}, should be float: `left${}`

<Link
  to="/"
  style={{
    float: 'left',
  }}
>
  ←
</Link>

Hm, seems like this one is still open... Just tried in both a .tsx file and a .js file (both set as JavaScript and JavaScript (React) syntaxes)

---

didn't test the other cases yet in my comment above

[meganrogge]

Worked well for most of your examples when I tested it. Seems like there are a lot of cases to cover

[karlhorky]

Hm, interesting... for me, I haven't seen a single one that does work. Maybe the publish didn't work properly?

For example, here's another one that fails (which is a very common pattern in React code):

The result of editing 'abc' here is href={{`abc${}`}}, should be href={`abc${}`}

<Link href={'abc'} />

Should this issue be reopened? Or should I create a new issue with the content of my comment above?

[meganrogge]

feel free to make a PR @karlhorky i'm quite occupied working on vscode at the moment, so could take me awhile to get to this

[karlhorky]

In Template String Converter 0.5.8 it seems like there's a new bug which is causing extra curly braces to appear outside of JSX code (in a file with TypeScript React syntax):

Kapture.2021-12-29.at.17.00.15.mp4

Opened #61 for this.

[meganrogge]

I just noticed that in your original example, if you delete the comment line, it will work

[meganrogge]

that's a case I don't have time for at the moment, but about to push a fix for the other cases you mention in this issue.

Done

[hunterwilhelm]

For anyone here looking for what the setting was named:

Template string converter add brackets to props

or in your JSON

"template-string-converter.addBracketsToProps": true