Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low contrast on command name in palette #57

Closed
willrowe opened this issue Sep 23, 2021 · 6 comments
Closed

Low contrast on command name in palette #57

willrowe opened this issue Sep 23, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@willrowe
Copy link

Describe the bug
When running a command with input in the command palette, both the foreground and background color are dark. This is happening with the Sublime Merge theme as well.

To Reproduce
Steps to reproduce the behavior:

  1. Set the theme to Meetio Theme High Contrast.sublime-theme.
  2. Set the color scheme to Meetio Deepocean.
  3. Open the command palette
  4. Select Arithmetic.

Expected behavior
Either the background or foreground should be a contrasting light color to make it easier to read.

Screenshots
Screen_Shot_2021-09-03_at_11 03 03_AM

@mauroreisvieira mauroreisvieira added the bug Something isn't working label Sep 24, 2021
@mauroreisvieira mauroreisvieira self-assigned this Sep 24, 2021
@mauroreisvieira
Copy link
Member

Hey @willrowe thanks for the report, will be fixed ASAP:

@willrowe
Copy link
Author

@mauroreisvieira any update on this?

@TerminalFi
Copy link
Member

Hey! Let me look into this

@TerminalFi
Copy link
Member

@willrowe @mauroreisvieira

The problem is that our Color Schemes are defining these three properties

popup_css
phantom_css
sheet_css

Sublime Text has a bug that if these are defined, they override all values. It should combine them with the default values but it doesn't. This is causing the bug that is listed in this ticket as well as a bug for popups and html content.

@mauroreisvieira we need to remove these three settings until Sublime Devs fix it.

sublimehq/sublime_text#3651

@mauroreisvieira
Copy link
Member

Hey, @TheSecEng thanks a lot for your help. I will fix that.

@willrowe
Copy link
Author

Thanks! That fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants