Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search icon not showing in quick panel #55

Closed
arturomartin opened this issue Jun 24, 2021 · 20 comments
Closed

Search icon not showing in quick panel #55

arturomartin opened this issue Jun 24, 2021 · 20 comments
Assignees
Labels
bug Something isn't working os: osx theme Issue related with theme

Comments

@arturomartin
Copy link

The search icon does not show in quick panel although the setting is set to true: "meetio_input_search_icon": true

Screenshot:
Screenshot on 2021-06-24 at 11-25-03

@mauroreisvieira
Copy link
Member

Hey @arturomartin, can you tell me what version of Sublime Text we are using and the OS?

@arturomartin
Copy link
Author

Of course, @mauroreisvieira

  • Sublime Text 4, Dev Channel, Build 4109
  • macOS Big Sur, 11.4

@mauroreisvieira
Copy link
Member

Hey, @arturomartin please check if the new version solves that issue.

@arturomartin
Copy link
Author

Sorry for the late answer, @mauroreisvieira

No, it doesn't seem it solved it :(

Screenshot on 2021-06-28 at 09-37-00

@mauroreisvieira
Copy link
Member

Hum, very strange, can you please remove that "meetio_input_search_icon" from your settings? By default, the icon should appear.

@arturomartin
Copy link
Author

I just did it and it's still not showing up. I even deleted all my settings (both of Meetio and Sublime Text) just to see if there was something causing it but no luck…

@mauroreisvieira
Copy link
Member

Can you please remove the Meetio Theme and install it again?

It seems that the icon is rendered, but without any color.

@arturomartin
Copy link
Author

Screenshot on 2021-06-28 at 11-15-46

After reinstalling, at first it seems the search icon is disabled by default, as you can see in the screenshot. If I try to enable it, the result is the same as in the previous screenshots.

@mauroreisvieira
Copy link
Member

If you change between Meetio Theme and Meetio Theme High Contrast the result is the same?

Can you please, open the console and check if exists any error?

@arturomartin
Copy link
Author

Yes, the result is the same.

The console doesn't show any kind of error, it just prints reloading settings Packages/User/Preferences.sublime-settings.

Maybe there's something wrong with the image itself? Don't think so, as I checked it in the package and it seems to be fine, but I'm running out of ideas :P

@arturomartin
Copy link
Author

arturomartin commented Jun 28, 2021

Mmm, sorry, my bad, I just found this in the console, but maybe it was when deleting and reinstalling the theme?:

unloading python 3.3 plugin Meetio Theme.customization
unloading python 3.3 plugin Meetio Theme.Icons
reloading settings Packages/Meetio Theme/Preferences.sublime-settings
ignored packages updated to: ["Meetio Theme", "Vintage"]
unloading python 3.3 plugin Meetio Theme.customization
unloading python 3.3 plugin Meetio Theme.Icons
reloading settings Packages/Meetio Theme/Preferences.sublime-settings
Unable to decode Packages/Meetio Theme/textures/spinner.png
Unable to decode Packages/Meetio Theme/textures/spinner1.png
Unable to decode Packages/Meetio Theme/textures/spinner10.png
Unable to decode Packages/Meetio Theme/textures/spinner11.png
Unable to decode Packages/Meetio Theme/textures/spinner2.png
Unable to decode Packages/Meetio Theme/textures/spinner3.png
Unable to decode Packages/Meetio Theme/textures/spinner4.png
Unable to decode Packages/Meetio Theme/textures/spinner5.png
Unable to decode Packages/Meetio Theme/textures/spinner6.png
Unable to decode Packages/Meetio Theme/textures/spinner7.png
Unable to decode Packages/Meetio Theme/textures/spinner8.png
Unable to decode Packages/Meetio Theme/textures/spinner9.png
Unable to decode Packages/Meetio Theme/textures/actions/branch.png
Unable to decode Packages/Meetio Theme/textures/actions/close.png
Unable to decode Packages/Meetio Theme/textures/actions/history.png
Unable to decode Packages/Meetio Theme/textures/actions/more.png
Unable to decode Packages/Meetio Theme/textures/actions/sidebar.png
Unable to decode Packages/Meetio Theme/textures/find/case_sensitive.png
Unable to decode Packages/Meetio Theme/textures/find/highlight_matches.png
Unable to decode Packages/Meetio Theme/textures/find/in_context.png
Unable to decode Packages/Meetio Theme/textures/find/in_selection.png
Unable to decode Packages/Meetio Theme/textures/find/preserve_case.png
Unable to decode Packages/Meetio Theme/textures/find/regex.png
Unable to decode Packages/Meetio Theme/textures/find/use_buffer.png
Unable to decode Packages/Meetio Theme/textures/find/use_gitignore.png
Unable to decode Packages/Meetio Theme/textures/find/whole_word.png
Unable to decode Packages/Meetio Theme/textures/find/wrap.png
Unable to decode Packages/Meetio Theme/textures/input/search.png
Unable to decode Packages/Meetio Theme/textures/navigation/arrow_down.png
Unable to decode Packages/Meetio Theme/textures/navigation/arrow_left_small.png
Unable to decode Packages/Meetio Theme/textures/navigation/arrow_right.png
Unable to decode Packages/Meetio Theme/textures/navigation/arrow_right_small.png
Unable to decode Packages/Meetio Theme/textures/overlay/background.png
Unable to decode Packages/Meetio Theme/textures/overlay/border.png
Unable to decode Packages/Meetio Theme/textures/overlay/shadow.png
Unable to decode Packages/Meetio Theme/textures/tab/dirty_dot.png
Unable to decode Packages/Meetio Theme/textures/tab/dirty_pencil.png
Unable to decode Packages/Meetio Theme/textures/tree/disclosure_collapsed.png
Unable to decode Packages/Meetio Theme/textures/tree/disclosure_expanded.png
Unable to decode Packages/Meetio Theme/textures/tree/folder_closed.png
Unable to decode Packages/Meetio Theme/textures/tree/folder_dup.png
Unable to decode Packages/Meetio Theme/textures/tree/folder_open.png
Unable to decode Packages/Meetio Theme/textures/vcs/vcs_added.png
Unable to decode Packages/Meetio Theme/textures/vcs/vcs_modified.png
Unable to decode Packages/Meetio Theme/textures/vcs/vcs_staged.png
Unable to decode Packages/Meetio Theme/textures/vcs/vcs_untracked.png

Edit:

Just unistalled and reinstalled it again and those errors are not showing anymore in the console:

Package Control: The package Meetio Theme has been removed
reloading settings Packages/User/Package Control.sublime-settings
ignored packages updated to: ["CSS", "Vintage"]
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
ignored packages updated to: ["CSS", "Meetio Theme", "Vintage"]
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Package Control.sublime-settings
ignored packages updated to: ["CSS", "Vintage"]
reloading settings Packages/Meetio Theme/Preferences.sublime-settings
reloading python 3.3 plugin Meetio Theme.customization
reloading python 3.3 plugin Meetio Theme.Icons
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings

@mauroreisvieira
Copy link
Member

mauroreisvieira commented Jun 28, 2021

Ok, let's try that:

  • Install PackageDev.
  • Go to command palette type: "PakageDev: Edit Current Theme"
  • Paste the following snippet:
{
    "variables": {},
    "rules": [
         {
            "class": "text_line_control",
            "parents": [
                {
                    "class": "overlay_control"
                }
            ],
            "layer1.opacity": 0,
            "layer2.inner_margin": [
                52,
                48,
                0,
                0
            ],
            "layer2.draw_center": false,
            "layer2.texture": "Meetio Theme/textures/input/search.png",
            "layer2.tint": "#f00",
            "layer2.opacity": 1,
            "content_margin": [
                52,
                10,
                10,
                10
            ],
            "settings": [
                "meetio_input_search_icon"
            ]
        },
    ],
}

The result:

Screenshot 2021-06-28 at 11 45 40 AM

@arturomartin
Copy link
Author

arturomartin commented Jun 28, 2021

I did that a few days ago, trying to force a color on that icon but no luck. I did it again now using just your snippet and PackageDev. No luck. It makes no sense…

Screenshot on 2021-06-28 at 11-51-27

@mauroreisvieira
Copy link
Member

Hey, can you pelase test to add that options in your settings:

"line_padding_bottom": 12,
"line_padding_top": 12,

@arturomartin
Copy link
Author

arturomartin commented Jun 28, 2021

I think you found it… Any value below 5 makes the icon disappear.

Screenshot on 2021-06-28 at 12-03-00

@mauroreisvieira
Copy link
Member

That blows my mind.

If the value of line padding is smaller than 5 the icon disappears.
I will try to understand the problem.

Thanks for the report and the help to find the issue.

I will warn you when that issue was solved.

@mauroreisvieira mauroreisvieira added bug Something isn't working os: osx theme Issue related with theme labels Jun 28, 2021
@mauroreisvieira mauroreisvieira self-assigned this Jun 28, 2021
@arturomartin
Copy link
Author

No, thanks to you @mauroreisvieira
Meetio is the best and most versatile theme I've used in a long time :)

@mauroreisvieira
Copy link
Member

Thank you so much for your words. 🙏🏻

Any suggestion to improve it's welcome.

@mauroreisvieira
Copy link
Member

Hey, @arturomartin issue solved.
Against thanks for your report.

@arturomartin
Copy link
Author

That was fast! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os: osx theme Issue related with theme
Projects
None yet
Development

No branches or pull requests

2 participants