(dev only) allow file download directly from django

[kuhnchris]

This is a development change only - no changes on prod!
... also requires setting PROVIDE_FILES_DIRECTLY = True in local_settings.py .

With this change, the entire package can be self-contained to test and develop without using a docker or devcontainers container.

[meeb]

You could probably just use settings.DEBUG along with a check for the Django development server for this rather than introduce another toggle that can be set separately from DEBUG. Given this feature is only going to be used in situations where the Django dev server is being used and also not behind an upstream nginx server you could do something like:

if settings.DEBUG and 'runserver' in sys.argv:
   # use manual FileResponse(...) download
else:
  # use nginx X-Accel-Redirect headers

as the feature toggle? Also if possible this should use pathlib and also contain a check for .is_file(), raising a 404 if the file doesn't exist before calling FileResponse(...). Thanks for the PR!

[kuhnchris]

Sure, I'll adapt accordingly and let you know if it's ready!

[kuhnchris]

Added check, also added pathlib for the final path, also changed the trigger to Debug + "runserver".
Let me know if that works for you. :-)

[meeb]

Much nicer, thanks!