Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media import with .mp4 files causes odd issues and Latest Downloads to be full of garbage #364

Closed
garbled1 opened this issue Mar 28, 2023 · 2 comments

Comments

@garbled1
Copy link
Contributor

garbled1 commented Mar 28, 2023

I ran a media import of my existing youtube channels when setting up tubesync, and it correctly found my .mp4 files, and my .mkv files. However, now, I have 2 strange issues:

  1. My latest downloads list on the dashboard, is full of ancient videos that were imported, with no dates.

  2. If I go look at one of those videos, it seems to think the file is a .mkv, when it's actually a .mp4, and then tells me the file size is 0 (in media details).

My guess is that it found the video with the .mp4 name, imported it, and then assumed it had a .mkv name when making the database entry?

I guess I don't care that the media info pages don't work, I just want the latest downloads to work, maybe ignore entries that the system thinks are 0-bytes?

@garbled1
Copy link
Contributor Author

Looks like a quick fix for this, is line 73 in sync/views.py, to add the ffilesize is not null =True like the largest files has, and suddenly the latest downloads screen works again for me.

@meeb
Copy link
Owner

meeb commented Mar 30, 2023

The sole use of the media import tool was basically just to link the media item to a file on disk and to set the is_downloaded flag to True just so that the media item wasn't downloaded again from YouTube. Lots of the other information (metadata, file size and what not) is taken from YouTube which doesn't happen with imported media so yes, if you import media lots of the media information will be blank or missing. Your suggestion sounds fine if imports break the dashboard stats, do you want to submit a PR for it?

@meeb meeb closed this as completed in 422d228 May 2, 2023
meeb added a commit that referenced this issue May 2, 2023
Fix #364 by checking the filesize is not null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants