Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle preordered albums #16

Closed
disconnect78 opened this issue Nov 16, 2023 · 2 comments
Closed

Handle preordered albums #16

disconnect78 opened this issue Nov 16, 2023 · 2 comments

Comments

@disconnect78
Copy link

When I synced my library I had an album preordered which had some of the tracks available. These were downloaded and a bandcamp_item_id.txt file was created in the album folder. This means that now the album has been properly released, it's being skipped so I only have the partial album downloaded.

Now that I realise this happens, I can manually delete the bandcamp_item_id.txt from the folder when a preordered album is released; but it may be preferable to simply skip downloading unreleased preorders altogether, eg. in __init__.py:

...
local_path = local_media.get_path_for_purchase(item)
if item.is_preorder == True:
    log.info(f'Item is preorder, skipping: "{item.band_name} / {item.item_title}" '
             f'(id:{item.item_id})')
    continue
elif local_media.is_locally_downloaded(item, local_path):
...
@meeb
Copy link
Owner

meeb commented Nov 17, 2023

Sounds like a decent addition, thanks! Do you want to create a PR for that?

@meeb meeb closed this as completed in ae824e0 May 4, 2024
@meeb
Copy link
Owner

meeb commented May 4, 2024

I've copy/pasted the above and checked it, seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants