Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure tax lines are generated for all items and shipping methods in cart #10372

Merged
merged 5 commits into from
Dec 1, 2024
Merged

fix: Ensure tax lines are generated for all items and shipping methods in cart #10372

merged 5 commits into from
Dec 1, 2024

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 1:22pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 1, 2024 1:22pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 1:22pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 1:22pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 1:22pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 1:22pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2024 1:22pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b430346

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl marked this pull request as ready for review November 29, 2024 16:14
@olivermrbl olivermrbl requested a review from a team as a code owner November 29, 2024 16:14
@olivermrbl olivermrbl changed the title fix: Generate tax lines for all items in cart fix: Ensure tax lines are generated for all items and shipping methods in cart Nov 29, 2024
riqwan
riqwan approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 💪🏻

adrien2p
adrien2p approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nasty bug 💪

@olivermrbl olivermrbl mentioned this pull request Dec 1, 2024
Closed
@olivermrbl olivermrbl linked an issue Dec 1, 2024 that may be closed by this pull request
[Bug]: Tax calculation removes tax lines for older items in addToCartWorkflow #10367
Closed
@olivermrbl olivermrbl merged commit eacd691 into develop Dec 1, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/tax-line-generation branch December 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@riqwan riqwan riqwan approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Tax calculation removes tax lines for older items in addToCartWorkflow
3 participants
@olivermrbl @riqwan @adrien2p