Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui,icons,ui-preset): Fix CodeBlock and Command components #10369

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Nov 29, 2024

What

  • Updates ui-preset and icons packages with latest changes from Figma.
  • Also noticed that all the Code related components were broken because the color and typography styles in Figma was renamed from Code Block/* to Code/* at some point. I have updated the components to use the proper styles, and tried to implement the CodeBlock as close to the Figma design as possible without introducing any breaking changes. The component will need to be revisited at a point when we are okay with introducing a breaking change, since a lot has been changed in the component as part of the Docs re-design. But this should make it more than usable for the time being.

Prev
Skærmbillede 2024-11-29 kl  16 47 43

Now

Skaermoptagelse.2024-11-29.kl.16.46.02.mov

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 4:03pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 4:03pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:03pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:03pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:03pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:03pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 4:03pm

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 008c4ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/ui-preset Patch
@medusajs/icons Patch
@medusajs/dashboard Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/toolbox Patch
create-medusa-app Patch
medusa-dev-cli Patch
integration-tests-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kasperkristensen kasperkristensen changed the title chore(icons,ui-preset): Sync with latest updates from Figma fix(ui,icons,ui-preset): Fix CodeBlock and Command components Nov 29, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperkristensen kasperkristensen merged commit 94f6265 into develop Nov 29, 2024
23 checks passed
@kasperkristensen kasperkristensen deleted the chore/update-design-system-nov branch November 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants