feat: rename type into installationType

medikoo · Nov 14, 2018 · 3e8ea0d · 3e8ea0d
1 parent 9095239
commit 3e8ea0d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lib/private/cli/index.js b/lib/private/cli/index.js
@@ -30,15 +30,15 @@ module.exports = async (command, packageName, inputOptions) => {
 	};
 	const updateProgress = () => {
 		cliFooter.updateProgress(
-			Array.from(ongoing, ([inProgressPackageName, { type }]) =>
-				format(`${ logWordForms.present[type] } %s`, inProgressPackageName)
+			Array.from(ongoing, ([inProgressPackageName, { installationType }]) =>
+				format(`${ logWordForms.present[installationType] } %s`, inProgressPackageName)
 			)
 		);
 	};
 	progressData.on("start", updateProgress);
 	progressData.on("end", ({ name: endedPackageName, progressData: packageProgressData }) => {
-		const { type } = packageProgressData;
-		log.notice(`${ logWordForms.past[type] } %s`, endedPackageName);
+		const { installationType } = packageProgressData;
+		log.notice(`${ logWordForms.past[installationType] } %s`, endedPackageName);
 		updateProgress();
 	});
 	try {

diff --git a/lib/private/install-package/index.js b/lib/private/install-package/index.js
@@ -40,7 +40,7 @@ module.exports = async (packageContext, userConfiguration, inputOptions, progres
 	const meta = (packageContext.meta = packagesMeta[name]);
 	const path = (packageContext.path = resolve(packagesPath, name));
 	const packageProgressData = {
-		type: (await isDirectory(path)) ? "update" : "install",
+		installationType: (await isDirectory(path)) ? "update" : "install",
 		hooks: { after: [] }
 	};
 

diff --git a/lib/private/install.js b/lib/private/install.js
@@ -22,7 +22,7 @@ module.exports = async (packageContext, userConfiguration, inputOptions, progres
 	// Ensure to emit "start" event in next event loop
 	await wait();
 
-	progressData.emit("start", { name, progressData: { type: "update" } });
+	progressData.emit("start", { name, progressData: { installationType: "update" } });
 
 	// Cleanup outcome of eventual previous npm crashes
 	await cleanupNpmInstall(packageContext);