fix: Case Insensitive Query Filters #5162
Open
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
changed the title
michael-genson
changed the title
|
Whoops, yes. Thank you for catching that this is Postgres specific. There's also https://www.postgresql.org/docs/current/citext.html if you want to do it in postgres directly. |
|
Ah, that's a nice feature. That would be a good idea if we ever redo tables, though at this point it's safer to just leave it as-is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
This makes all query filters that involve strings case-insensitive. For instance:
name = "my recipe"will find a recipe titled "My Recipe"name LIKE "%STEW"will find a recipe titled "Beef Stew"Which issue(s) this PR fixes:
(REQUIRED)
Fixes #5157
Special notes for your reviewer:
(fill-in or delete this section)
From a pure application standpoint you could argue that there are fringe cases where this would be undesired, but I argue that in a recipe manager you would never want case sensitivity. We already do case insensitivity automatically on ordering anyway:
mealie/mealie/repos/repository_generic.py
Lines 403 to 405 in 46d28bd
Testing
(fill-in or delete this section)
Added a few tests.