Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Backend configuration docs: Unclear Webworker documentation #3165

Closed
5 of 6 tasks
Millio345 opened this issue Feb 13, 2024 · 1 comment · Fixed by #3167
Closed
5 of 6 tasks

[BUG] - Backend configuration docs: Unclear Webworker documentation #3165

Millio345 opened this issue Feb 13, 2024 · 1 comment · Fixed by #3167
Labels
bug: confirmed bug Something isn't working documentation Improvements or additions to documentation

Comments

@Millio345
Copy link

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue (title field is above this).
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

On the backend config, located at https://nightly.mealie.io/documentation/getting-started/installation/backend-config/ , there's a few issues:

  • WORKERS_PER_CORE, MAX_WORKERS and WEB_CONCURRENCY have text 'More info here' that should be a link but is not, f.e. "More info [here][max_workers]"
  • MAX_WORKERS description says "Default is not set meaning unlimited" , yet right next to it in the default column it says "1"

The main reason I was looking this up is because the example docker compose files include these settings and I was trying to understand what they did and why they needed to be specifically included in the docker environment variables. If "1" is indeed the default for MAX_WORKERS and WEB_CONCURRENCY and it's strongly recommended not to change these settings, then maybe it'd be better to just remove those options from the example docker compose?

Steps to Reproduce

  1. Go to https://nightly.mealie.io/documentation/getting-started/installation/backend-config/
  2. Scroll down to Webworker

Please provide relevant logs

N/A

Mealie Version

No response

Deployment

Docker (Linux)

Additional Deployment Details

No response

@Millio345 Millio345 added bug Something isn't working triage labels Feb 13, 2024
@Kuchenpirat Kuchenpirat added documentation Improvements or additions to documentation bug: confirmed and removed triage labels Feb 13, 2024
@Kuchenpirat
Copy link
Collaborator

Hey thanks for raising this issue.
Seems like the pages have been moved and some links have not been copied over.
This should be an easy fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants