Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share attribute conversion from MDXHAST to JSX with hast-to-hyperscript #716

Closed
johno opened this issue Aug 6, 2019 · 1 comment · Fixed by #1039
Closed

Share attribute conversion from MDXHAST to JSX with hast-to-hyperscript #716

johno opened this issue Aug 6, 2019 · 1 comment · Fixed by #1039
Labels
👯 no/duplicate Déjà vu 🦋 type/enhancement This is great to have

Comments

@johno
Copy link
Member

johno commented Aug 6, 2019

As brought up in #715, we're currently duplicating a lot of logic with hast-to-hyperscript. We should investigate how we can share the implementation, possibly by breaking out some of the logic into another file or package.
@johno johno added 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on labels Aug 6, 2019
This was referenced Apr 29, 2020
Closed
Merged
@johno
Copy link
Member Author

johno commented May 20, 2020

Going to close this since it's landed in the next branch for v2.

@johno johno closed this as completed May 20, 2020
@wooorm wooorm added 👯 no/duplicate Déjà vu and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👯 no/duplicate Déjà vu 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite how MDX is parsed mdx-js/mdx
2 participants
@wooorm @johno