feat: toolbar className customization #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebEferen
changed the title
petyosi
reviewed
Oct 7, 2024
| @@ -20,6 +20,7 @@ function App() { | |||
| markdown="Hello world" | |||
| plugins={[ | |||
| toolbarPlugin({ | |||
| toolbarClassName: 'my-classname', | |||
There was a problem hiding this comment.
Why not just className, or , mayberootElementClassName?
There was a problem hiding this comment.
@petyosi to keep naming consistent across the toolbar component. There is toolbarContent, so toolbarClassName points user directly to the Root element (so the wrapper around the content itself).
There was a problem hiding this comment.
toolbarClassName gives user pretty good understanding where this class will be applied (also good for the future, when there might be more classess for different elements).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As my second PR, I would like to introduce the possibility to customize the toolbar className. It is helpful when you would like to style the toolbar (for example dark mode).