Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect length passed in the case of revert #338

Open
Ahmed-Aghadi opened this issue Nov 15, 2024 · 0 comments
Open

Incorrect length passed in the case of revert #338

Ahmed-Aghadi opened this issue Nov 15, 2024 · 0 comments

Comments

@Ahmed-Aghadi
Copy link

The aggregate3 function and aggregate3Value function have same assembly block to revert but aggregate3Value revert with 0x84 length whereas aggregate3 revert with 0x64 length. I believe both should be 0x64. Although there shouldn't be any problem because in worst case scenario ( according to me ) only last 4 bytes will be dirty but even then as we're setting 0x17 to be length of the string "Multicall3: call failed" so extra bytes shouldn't be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant