Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discord): add /discord redirect with updated signup link #9976

Merged
merged 3 commits into from
Nov 8, 2023
Merged

fix(discord): add /discord redirect with updated signup link #9976

merged 3 commits into from
Nov 8, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 8, 2023 •
edited
Loading

Summary

Fixes #9975.

Problem

The Discord link was expired.

Solution

Adds a redirect /discord to the current signup link, and use it everywhere.

Screenshots

Before

image

After

image

How did you test this change?

Ran npm i && npm start in /cloud-function and tested with cURL:

$ curl -I http://localhost:5100/discord
HTTP/1.1 302 Found
Cache-Control: max-age=2592000,public
Location: https://discord.gg/Gt4Qf6q67h
Vary: Accept
Content-Type: text/plain; charset=utf-8
Content-Length: 51
Date: Wed, 08 Nov 2023 14:35:24 GMT
Connection: keep-alive
Keep-Alive: timeout=5

@caugner caugner requested a review from a team as a code owner November 8, 2023 14:19
@github-actions github-actions bot added plus work around features related to MDN Plus copy Copy changes to hard-coded texts on the site labels Nov 8, 2023
@caugner caugner force-pushed the update-discord-link branch from e59794a to 13f6f23 Compare November 8, 2023 14:40
@github-actions github-actions bot added the redirects all things related to redirecting label Nov 8, 2023
@caugner caugner force-pushed the update-discord-link branch from 13f6f23 to dd0be16 Compare November 8, 2023 14:42
@caugner caugner changed the title fix(discord): update Discord link fix(discord): add /discord redirect with updated signup link Nov 8, 2023
LeoMcA
LeoMcA approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🚀

@caugner caugner merged commit 3544491 into main Nov 8, 2023
@caugner caugner deleted the update-discord-link branch November 8, 2023 15:00
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
@caugner @gurezo
fix(discord): add /discord redirect with updated signup link (mdn#9976)
0b6df74 
* fix(discord): replace expired Discord link

* chore(plus/docs): link to issue report forms

* chore(fundamental-redirects): add /discord redirect
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
@caugner @gurezo
fix(discord): add /discord redirect with updated signup link (mdn#9976)
106c928 
* fix(discord): replace expired Discord link

* chore(plus/docs): link to issue report forms

* chore(fundamental-redirects): add /discord redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees
No one assigned
Labels
copy Copy changes to hard-coded texts on the site plus work around features related to MDN Plus redirects all things related to redirecting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"MDN Chat" link in the website footer is expired
2 participants
@caugner @LeoMcA