-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(links): adopt visited link colors from Firefox #9961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the design side!
Wouldn't the name '--text-link-visited' be more appropriate than the '--text-visited'? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Excellent question! The CSS Color Module draft defines |
Makes sense. |
Ensures that visited links are readable in all browsers, including Safari.
Ensures that visited links are readable in all browsers, including Safari.
Summary
Fixes #9958.
Problem
Visited links are not readable in Safari with the dark theme.
Solution
Define visited link colors rathern than relying on browser defaults, adopting the visited link colors of Firefox.
Screenshots
How did you test this change?