fix(macros/LiveSampleLink): add fallback to prebuilt samples #9738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
macros
fiji-flo
force-pushed
the
fix-live-sample-link
branch
from
743f8e7 to
73557ad
Compare
caugner
changed the title
caugner
approved these changes
Sep 28, 2023
caugner
added
the
live-samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
LiveSampleLinkmacro for now and consolidate live samples domains.Problem
LiveSampleLinkpointing to an empty page.Solution
Enforce fallback to prebuild samples.
How did you test this change?
Deploying to stage now.