Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump @webref/css from 6.0.0 to 6.7.1 #9731

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore(deps): bump @webref/css from 6.0.0 to 6.7.1 #9731

merged 2 commits into from
Nov 13, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 26, 2023 •
edited
Loading

Summary

Fixes #10004.

Problem

We recently upgraded to @webref/css v6, but Dependabot didn't upgrade to the latest minor/patch version yet.

Solution

Upgade manually.

How did you test this change?

TBD

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 26, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 18, 2023
@caugner caugner force-pushed the bump-webref-css-to-latest-v6 branch from 79d5cb2 to d31d8ee Compare November 10, 2023 13:29
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Nov 10, 2023
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 10, 2023
@caugner caugner marked this pull request as ready for review November 10, 2023 20:50
@caugner caugner requested review from mdn-bot and a team as code owners November 10, 2023 20:50
caugner
caugner commented Nov 10, 2023
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's why this isn't merged yet:

6.0.0 6.7.1
image image

@caugner caugner marked this pull request as draft November 10, 2023 20:58
@OnkarRuikar
Copy link
Contributor

Here's why this isn't merged yet:

What's wrong? Here <url> is a type and <url()> is a function.
With the latest version it is reflected accurately <url>=<url()>|<src()> as per the latest spec.

@caugner caugner marked this pull request as ready for review November 13, 2023 09:33
@caugner
Copy link
Contributor Author

caugner commented Nov 13, 2023

What's wrong? Here <url> is a type and <url()> is a function.
With the latest version it is reflected accurately <url>=<url()>|<src()> as per the latest spec.

Oh, you're right, apparently I didn't look closely enough.

caugner
caugner commented Nov 13, 2023
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, because it's "just" a minor dependency update.

@caugner caugner merged commit 4a50067 into main Nov 13, 2023
@caugner caugner deleted the bump-webref-css-to-latest-v6 branch November 13, 2023 09:33
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formal syntax in PR Preview is different
2 participants
@caugner @OnkarRuikar