Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-help): use prism for syntax highlighting #9510

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

fiji-flo
Copy link
Contributor

Summary

Syntax highlighting for AI-Help answers.

Problem

Code examples looked different than anywhere else.

Solution

Use prism to style code samples in AI-Help answers.


Screenshots

Before

image

After

image

@fiji-flo fiji-flo requested a review from caugner August 17, 2023 14:37
@github-actions github-actions bot added the plus work around features related to MDN Plus label Aug 17, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits.

client/src/plus/ai-help/index.tsx Outdated Show resolved Hide resolved
client/src/plus/ai-help/index.tsx Outdated Show resolved Hide resolved
client/src/plus/ai-help/index.tsx Outdated Show resolved Hide resolved
client/src/plus/ai-help/index.tsx Outdated Show resolved Hide resolved
@caugner caugner merged commit e9f49cd into main Aug 18, 2023
@caugner caugner deleted the ai-help-syntax-highlight branch August 18, 2023 13:59
@caugner
Copy link
Contributor

caugner commented Aug 18, 2023

FWIW

File sizes after gzip:

  427.21 kB          build/static/js/482.d159a27c.chunk.js
  168.09 kB (+45 B)  build/static/js/main.8dd2bfd8.js
  50.25 kB           build/static/js/660.f3ba2c31.chunk.js
  28.03 kB           build/static/css/main.b9154aa3.css
  26.26 kB           build/static/js/966.3f90d3e3.chunk.js
  11.01 kB           build/static/js/473.9fc254d7.chunk.js
  7.15 kB (+340 B)   build/static/js/400.49ccf0cc.chunk.js
  6.75 kB            build/static/js/768.40509498.chunk.js
  6.3 kB             build/static/js/68.bd5e344e.chunk.js
  5.88 kB            build/static/js/browser-compatibility-table.7ba9c730.chunk.js
  5.47 kB            build/static/js/693.d6326b63.chunk.js
  5.18 kB            build/static/js/996.bf624561.chunk.js
  4.66 kB            build/static/js/606.6e843052.chunk.js
  4.29 kB            build/static/js/69.d07492fb.chunk.js
  4.12 kB            build/static/js/211.c7d57a96.chunk.js
  4.11 kB            build/static/js/863.8caec159.chunk.js
  3.5 kB             build/static/js/57.45d5a9d9.chunk.js
  3.48 kB            build/static/js/717.fae76663.chunk.js
  3.11 kB            build/static/js/662.0d1c5c1b.chunk.js
  2.02 kB (+32 B)    build/static/css/400.46f1bacf.chunk.css
  1.88 kB            build/static/js/791.c4a8d43f.chunk.js
  1.55 kB            build/static/css/473.0d5e2f6d.chunk.css
  1.45 kB            build/static/css/606.82f4e2d2.chunk.css
  1.32 kB            build/static/css/57.57c96ebf.chunk.css
  1.15 kB            build/static/css/518.614dbbf1.chunk.css
  846 B              build/static/js/979.80842b35.chunk.js
  814 B              build/static/js/507.a20b1659.chunk.js
  721 B              build/static/css/693.90ea2bbb.chunk.css
  654 B              build/static/css/996.feade3fe.chunk.css
  621 B              build/static/css/768.32df508f.chunk.css
  560 B              build/static/js/419.1bff5d09.chunk.js
  526 B              build/static/css/211.02c1c08f.chunk.css
  296 B              build/static/css/662.631950ad.chunk.css
  196 B              build/static/css/419.794c818f.chunk.css
  186 B              build/static/js/518.a5b6aabb.chunk.js
  145 B              build/static/css/979.7bf6dfc6.chunk.css
  132 B              build/static/css/507.933c43f0.chunk.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants