feat(blog): show newsletter form or link below posts #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
fiji-flo
approved these changes
Jun 13, 2023
client/src/newsletter/index.scss
Outdated
Comment on lines
15
to
20
| .blog-container.post + & { | ||
| h2 { | ||
| font: var(--type-heading-h3); | ||
| margin: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: I'd move this to the blog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is one for "hide whitespace changes" :)
Summary
https://mozilla-hub.atlassian.net/browse/MP-394
Problem
We don't promote the newsletter
Solution
Promote it below blog posts, show a link to settings for users logged in
Screenshots
Before
After
logged in:
logged out: