fix(sidebar): incorrect offset and z-index on mobile #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove --z-index-top variable, and split into per-element variables - not everything can be on top! remove some unnecessary z-indexes due to relative positioning I intend to follow up with another commit removing the rest of the reused/unnecessary z-indexes later - but don't want to block fixing this issue with that fixes #8646 fixes #8702
LeoMcA
force-pushed
the
sidebar-z-index-offset
branch
from
c448c85 to
adcd2c9
Compare
fiji-flo
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #8646
fixes #8702
remove --z-index-top variable, and split into per-element variables -
not everything can be on top!
remove some unnecessary z-indexes due to relative positioning
I intend to follow up with another PR removing the rest of the
reused/unnecessary z-indexes later - but don't want to block fixing this
issue with that
Problem
Solution
Screenshots
Before
After