Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-help): show stopped message once + restore search animation #10632

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 1, 2024

Summary

Problem

Recent changes caused two regressions:

  1. The "Stopped answering" message was potentially showing multiple times.
  2. The icon next to "Searching for MDN content…" was no longer blinking.

Solution

  1. Move the "Stopped " message out of CSS into React.
  2. Add the missing active class for the search status.

Screenshots

Before

After

Screen.Recording.2024-03-01.at.15.29.15.mov

How did you test this change?

Asked a question locally and stopped when it was generating content in a nested list.

@caugner caugner requested a review from a team as a code owner March 1, 2024 14:30
@github-actions github-actions bot added plus work around features related to MDN Plus plus:ai-help labels Mar 1, 2024
@caugner caugner requested a review from argl March 15, 2024 11:07
@caugner caugner merged commit e24a7cc into main Mar 15, 2024
15 checks passed
@caugner caugner deleted the fix-ai-help-regressions branch March 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus:ai-help plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants