fix(ai-help): send correct context when editing question #10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We defaulted to the 0 when traversing the tree for context. This breaks editing question.
github-actions
bot
added
plus
caugner
reviewed
Feb 14, 2024
caugner
requested changes
Feb 14, 2024
caugner
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
LGTM, and tested locally, just two nits:
- Making the third parameter of
stateToMessagePath()an options object. - Updating the PR description (I already added screenshots) to reflect the latest insights of what the problem and solution was (it wasn't only defaulting to 0, was it?).
| @@ -110,27 +110,32 @@ export interface MessageTreeState { | |||
|
|
|||
| export function stateToMessagePath( | |||
| state: MessageTreeState, | |||
| path: number[] | |||
| path: number[], | |||
| traverseWithDefault: boolean = false | |||
There was a problem hiding this comment.
Sorry, one last nit is that it would be better to make this an options object:
Suggested change
| traverseWithDefault: boolean = false | |
| { traverseWithDefault = false }: { traverseWithDefault: boolean } |
Like this, it is more clear where we're calling it what the true stands for.
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Traverse the message tree in a correct way when gathering context.
Problem
We sent the wrong context when editing the first question (namely including the question/answer of the original version of the question), because we defaulted to 0 when traversing the message tree for context.
Solution
Add a
traverseWithDefaultflag to only default to 0 when initializing.Screenshots