Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system could be more helpful when reporting slug-folder naming discrepencies #10277

Open
3 tasks done
captainbrosset opened this issue Jan 8, 2024 · 0 comments
Open
3 tasks done
Labels
accepting PR We invite you to open a PR to resolve this issue. idle p3 We don't have visibility when this will be addressed.

Comments

@captainbrosset
Copy link
Contributor

Summary

While working on PR mdn/content#31176 I got this error:

Error: The document's slug (Web/API/TextFormatUpdateEvent/getTextFormats) doesn't match its disk folder name (en-us/web/api/textformatupdateevent/getTextFormats)

I stayed blocked for a long time figuring out what was wrong. I read the two strings many many times, trying to find a typo that I, somehow, couldn't find.

It turns out the folder name was camelCase, when really it should have been lowercase.

The error message is misleading here. It's telling me that the folder name doesn't match the slug, but really it does.

Can we make the error message say something like "please lowercase the folder name" in this scenario?

URL

mdn/content#31176

Reproduction steps

  1. Make the mistake of camelcasing a folder name
  2. Push the branch and create a PR on mdn/content
  3. Wait for the build to kick in and report the issue

Expected behavior

The error message should be more obvious. I'm sure this has already bitten many people in the past.

Actual behavior

The error message doesn't tell you what the actual problem is.

Device

Desktop

Browser

Other (specify below)

Browser version

Other version (specify below)

Operating system

Other (specify below)

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 8, 2024
@argl argl added p3 We don't have visibility when this will be addressed. accepting PR We invite you to open a PR to resolve this issue. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 31, 2024
@github-actions github-actions bot added the idle label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. idle p3 We don't have visibility when this will be addressed.
Projects
None yet
Development

No branches or pull requests

2 participants