-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(baseline): update icons, add text to feedback link #10172
Conversation
also address review from prior PR: #10128 (review) - configure svgo to automatically remove height/width and add viewbox, and do so on baseline icons - use classes instead of first/last-child for links - don't show copy if low_date is undefined (it should always be defined if baseline is low/high, but just in case)
This pull request has merge conflicts that must be resolved before it can be merged. |
This is, at least for now, intentional, as the widely available badge doesn't have a year attached, so the "widely available" text lives at the same level as the year in the information hierarchy, with "newly available" more of a qualifier, like so:
Though of course, the intent here is to meet developers expectations, so thanks for your feedback - we'll take it on board, and make sure to fill out the survey (if you haven't already) to leave more feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one consistency nit.
Summary
updates icons to subtly different colours
adds text to feedback link to make more visible
address review from prior PR:
#10128 (review)
configure svgo to automatically remove height/width and add viewbox,and do so on baseline icons
if baseline is low/high, but just in case)
Screenshots
Showing images alternating between new and old to show differences better:
How did you test this change?
Loaded each variant locally, https://developer.mozilla.org/en-US/build.json shows pages for each status.