Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(baseline): update icons, add text to feedback link #10172

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Dec 12, 2023

Summary

updates icons to subtly different colours

adds text to feedback link to make more visible

address review from prior PR:
#10128 (review)

  • configure svgo to automatically remove height/width and add viewbox,
    and do so on baseline icons
  • use classes instead of first/last-child for links
  • don't show copy if low_date is undefined (it should always be defined
    if baseline is low/high, but just in case)

Screenshots

Showing images alternating between new and old to show differences better:

Screenshot 2023-12-12 at 18-54-17 MDN Web Docs
Screenshot 2023-12-12 at 18-54-14 CanvasRenderingContext2D isContextLost() method - Web APIs MDN
Screenshot 2023-12-12 at 18-54-09 MDN Web Docs
Screenshot 2023-12-12 at 18-54-05 @layer - CSS Cascading Style Sheets MDN
Screenshot 2023-12-12 at 18-54-01 MDN Web Docs
Screenshot 2023-12-12 at 18-53-55 font-family - CSS Cascading Style Sheets MDN
Screenshot 2023-12-12 at 18-53-36 MDN Web Docs
Screenshot 2023-12-12 at 18-53-32 CanvasRenderingContext2D isContextLost() method - Web APIs MDN
Screenshot 2023-12-12 at 18-53-28 MDN Web Docs
Screenshot 2023-12-12 at 18-53-25 @layer - CSS Cascading Style Sheets MDN
Screenshot 2023-12-12 at 18-53-21 MDN Web Docs
Screenshot 2023-12-12 at 18-53-15 font-family - CSS Cascading Style Sheets MDN


How did you test this change?

Loaded each variant locally, https://developer.mozilla.org/en-US/build.json shows pages for each status.

also address review from prior PR:
#10128 (review)
- configure svgo to automatically remove height/width and add viewbox,
  and do so on baseline icons
- use classes instead of first/last-child for links
- don't show copy if low_date is undefined (it should always be defined
  if baseline is low/high, but just in case)
@LeoMcA LeoMcA requested a review from a team as a code owner December 12, 2023 19:04
@LeoMcA LeoMcA requested a review from mdn-bot as a code owner December 13, 2023 10:15
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 13, 2023
@LeoMcA LeoMcA requested a review from caugner December 13, 2023 10:15
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Dec 13, 2023
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Dec 13, 2023
@OnkarRuikar
Copy link
Contributor

"Newly available" and "Widely available" badges are not consistent with each other. Can we make "Widely available" same as the other:
_1

_2

@LeoMcA
Copy link
Member Author

LeoMcA commented Dec 14, 2023

"Newly available" and "Widely available" badges are not consistent with each other.

This is, at least for now, intentional, as the widely available badge doesn't have a year attached, so the "widely available" text lives at the same level as the year in the information hierarchy, with "newly available" more of a qualifier, like so:

  • Widely available
  • 2021 (Newly available)
  • 2022 (Newly available)
  • 2023 (Newly available)
  • Limited availability

Though of course, the intent here is to meet developers expectations, so thanks for your feedback - we'll take it on board, and make sure to fill out the survey (if you haven't already) to leave more feedback.

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one consistency nit.

client/src/document/baseline-indicator.tsx Outdated Show resolved Hide resolved
@LeoMcA LeoMcA merged commit 7b79d32 into main Dec 14, 2023
15 checks passed
@LeoMcA LeoMcA deleted the baseline-fixes branch December 14, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants