Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Code Preview Different from Code Along Example #784

Open
danieletie opened this issue Jan 7, 2025 · 4 comments
Open

Final Code Preview Different from Code Along Example #784

danieletie opened this issue Jan 7, 2025 · 4 comments

Comments

@danieletie
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Learn_web_development/Extensions/Forms/Your_first_form

What specific section or headline is this issue about?

Basic form styling

What information was incorrect, unhelpful, or incomplete?

The code on the live preview linking to first form html in the Basic Form Styling section displays the below code

<form action="/my-handling-form-page" method="post">
  <ul>
  <li>
    <label for="name">Name:</label>
    <input type="text" id="name" name="user_name" />
  </li>
  <li>
    <label for="mail">E-mail:</label>
    <input type="email" id="mail" name="user_mail" />
  </li>
  <li>
    <label for="msg">Message:</label>
    <textarea id="msg" name="user_message"></textarea>
  </li>
  <li class="button">
    <button type="submit">Send your message</button>
  </li>
  </ul>
</form>

But coding along from the previous sections shows the below code

<form action="/my-handling-form-page" method="post">
  <p>
    <label for="name">Name:</label>
    <input type="text" id="name" name="user_name" placeholder="Your name"/>
  </p>
  <p>
    <label for="mail">Email:</label>
    <input type="email" id="mail" name="user_email" placeholder="[email protected]"/>
  </p>
  <p>
    <label for="msg">Message:</label>
    <textarea id="msg" name="user_message"></textarea>
  </p>
  <p class="button">
    <button type="submit">Send your message</button>
  </p>
</form>

Shows that the code along is not in sync with the final example at the beginning of the

What did you expect to see?

I'm seeing this

image

instead of this from following along the code

image

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@danieletie danieletie added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 7, 2025
@Josh-Cena
Copy link
Member

mdn/content#36013 changed the <ul> to <p>. We need to sync learning-area code accordingly.

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 7, 2025
@wbamberg wbamberg transferred this issue from mdn/content Jan 7, 2025
@danieletie
Copy link
Author

Hello, In case of next time and I want to contribute to make this kind of change? What do I need to do to get assigned an issue?
Do I just fork the necessory repo, make the changes and submit a pull request?

cc: @Josh-Cena & @wbamberg

@Josh-Cena
Copy link
Member

Yes, you just submit a PR containing the changes you want to see. No need to ask for assignment.

@wbamberg
Copy link
Contributor

wbamberg commented Jan 8, 2025

@danieletie , are you offering to fix this issue? Would be much appreciated if you wanted to. I think the relevant files are https://github.com/mdn/learning-area/tree/main/html/forms/your-first-HTML-form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants