From ecf3c5d1ceb3f9e6a398de2773626aa96af23158 Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Fri, 28 Jul 2023 17:17:42 +0530 Subject: [PATCH 01/14] Feature: provide automated PR reivews for linting related changes --- .github/workflows/pr-check_markdownlint.yml | 50 ---------- .github/workflows/pr-review-lint.yml | 103 ++++++++++++++++++++ 2 files changed, 103 insertions(+), 50 deletions(-) delete mode 100644 .github/workflows/pr-check_markdownlint.yml create mode 100644 .github/workflows/pr-review-lint.yml diff --git a/.github/workflows/pr-check_markdownlint.yml b/.github/workflows/pr-check_markdownlint.yml deleted file mode 100644 index abdbff3e6766866..000000000000000 --- a/.github/workflows/pr-check_markdownlint.yml +++ /dev/null @@ -1,50 +0,0 @@ -name: Markdownlint (PR files) - -on: - pull_request: - branches: - - main - paths: - - .nvmrc - - "**/*.md" - -jobs: - lint-docs: - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v3 - - - name: Get changed files - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - BASE_SHA: ${{ github.event.pull_request.base.sha }} - HEAD_SHA: ${{ github.event.pull_request.head.sha }} - run: | - # Use the GitHub API to get the list of changed files - # documenation: https://docs.github.com/rest/commits/commits#compare-two-commits - DIFF_DOCUMENTS=$(gh api repos/{owner}/{repo}/compare/${{ env.BASE_SHA }}...${{ env.HEAD_SHA }} \ - --jq '.files | .[] | select(.status|IN("added", "modified", "renamed", "copied", "changed")) | .filename') - # filter out files that are not markdown - DIFF_DOCUMENTS=$(echo "${DIFF_DOCUMENTS}" | egrep -i "^files/.*\.md$" | xargs) - echo "DIFF_DOCUMENTS=${DIFF_DOCUMENTS}" >> $GITHUB_ENV - - - name: Setup Node.js environment - uses: actions/setup-node@v3 - with: - node-version-file: ".nvmrc" - cache: yarn - - - name: Install all yarn packages - run: yarn --frozen-lockfile - env: - # https://github.com/microsoft/vscode-ripgrep#github-api-limit-note - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - - name: Lint markdown files - run: | - echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json" - files_to_lint="${{ env.DIFF_DOCUMENTS }}" - yarn markdownlint-cli2 ${files_to_lint} - echo "Linting front-matter" - node scripts/front-matter_linter.js ${files_to_lint} diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml new file mode 100644 index 000000000000000..91075b6a59a28a3 --- /dev/null +++ b/.github/workflows/pr-review-lint.yml @@ -0,0 +1,103 @@ +name: Add lint reviews to PRs + +on: + pull_request: + branches: + - main + paths: + - .nvmrc + - "**/*.md" + +jobs: + lint-docs: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v3 + + - name: Get changed files + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + BASE_SHA: ${{ github.event.pull_request.base.sha }} + HEAD_SHA: ${{ github.event.pull_request.head.sha }} + run: | + # Use the GitHub API to get the list of changed files + # documentation: https://docs.github.com/rest/commits/commits#compare-two-commits + DIFF_DOCUMENTS=$(gh api repos/{owner}/{repo}/compare/${{ env.BASE_SHA }}...${{ env.HEAD_SHA }} \ + --jq '.files | .[] | select(.status|IN("added", "modified", "renamed", "copied", "changed")) | .filename') + # filter out files that are not markdown + DIFF_DOCUMENTS=$(echo "${DIFF_DOCUMENTS}" | egrep -i "^files/.*\.md$" | xargs) + echo "DIFF_DOCUMENTS=${DIFF_DOCUMENTS}" >> $GITHUB_ENV + + - name: Setup Node.js environment + uses: actions/setup-node@v3 + with: + node-version-file: ".nvmrc" + cache: yarn + + - name: Install all yarn packages + run: yarn --frozen-lockfile + env: + # https://github.com/microsoft/vscode-ripgrep#github-api-limit-note + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - name: Lint and format markdown files + run: | + #echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json" + echo "Running markdownlint --fix" + files_to_lint="${{ env.DIFF_DOCUMENTS }}" + MD_LINT_STATUS=0 + MD_LINT_LOG=$(yarn markdownlint-cli2 --fix ${files_to_lint} 2>&1) || MD_LINT_STATUS=1 + echo "MD_LINT_LOG<> $GITHUB_ENV + echo "${MD_LINT_LOG}" >> $GITHUB_ENV + echo "EOF" >> $GITHUB_ENV + echo "MD_LINT_STATUS=${MD_LINT_STATUS}" >> $GITHUB_ENV + + echo "Linting front-matter" + FM_LINT_STATUS=0 + FM_LINT_LOG=$(node scripts/front-matter_linter.js --fix true ${files_to_lint} 2>&1) || FM_LINT_STATUS=1 + echo "FM_LINT_LOG<> $GITHUB_ENV + echo "${FM_LINT_LOG}" >> $GITHUB_ENV + echo "EOF" >> $GITHUB_ENV + echo "FM_LINT_STATUS=${FM_LINT_STATUS}" >> $GITHUB_ENV + + echo "Running Prettier" + yarn prettier -w ${files_to_lint} + + - name: Setup reviewdog + uses: reviewdog/action-setup@v1 + with: + reviewdog_version: latest + + - name: Suggest changes using diff + env: + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + TMPFILE=$(mktemp) + git diff >"${TMPFILE}" + git stash -u && git stash drop + echo "Running rd" + reviewdog \ + -name="mdn-linter" \ + -f=diff \ + -f.diff.strip=1 \ + -reporter=github-pr-review < "${TMPFILE}" + + - name: Add reviews for markdonwlint errors + if: env.MD_LINT_STATUS == '1' + env: + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + echo "${{ env.MD_LINT_LOG }}" | \ + reviewdog \ + -efm="%f:%l:%c %m" \ + -efm="%f:%l %m" \ + -name="markdownlint" \ + -diff="git diff" \ + -reporter="github-pr-review" + + - name: Log and fail if front-matter linter fails + if: env.FM_LINT_STATUS == '1' + run: | + echo "${{ env.FM_LINT_LOG }}" + exit 1 From f1a2ba64d0f4dbf6d5fe81b411603d6c7a89a2ad Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Fri, 28 Jul 2023 17:43:56 +0530 Subject: [PATCH 02/14] change token --- .github/workflows/pr-review-lint.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 91075b6a59a28a3..9de32c85d9c45e7 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -71,12 +71,11 @@ jobs: - name: Suggest changes using diff env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ inputs.GITHUB_TOKEN }} run: | TMPFILE=$(mktemp) git diff >"${TMPFILE}" git stash -u && git stash drop - echo "Running rd" reviewdog \ -name="mdn-linter" \ -f=diff \ @@ -86,7 +85,7 @@ jobs: - name: Add reviews for markdonwlint errors if: env.MD_LINT_STATUS == '1' env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ inputs.GITHUB_TOKEN }} run: | echo "${{ env.MD_LINT_LOG }}" | \ reviewdog \ From 51328d9b4ccfd0eef524eb4c724642203dd71f2f Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Fri, 28 Jul 2023 17:45:05 +0530 Subject: [PATCH 03/14] introducing errors for testing --- files/en-us/games/index.md | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/files/en-us/games/index.md b/files/en-us/games/index.md index 56dc31db3e47d99..2b87ba8f78d02cf 100644 --- a/files/en-us/games/index.md +++ b/files/en-us/games/index.md @@ -1,22 +1,33 @@ --- title: Game development -slug: Games page-type: landing-page +slug: Games --- {{GamesSidebar}} Gaming is one of the most popular computer activities. New technologies are constantly arriving to make it possible to develop better and more powerful games that can be run in any standards-compliant web browser. -## Develop web games +```css +body { background-color: aqua; } +div { + color: red; +} +``` + +# Develop web games Welcome to the MDN game development center! In this area of the site, we provide resources for web developers wanting to develop games. You will find many useful tutorials and technique articles in the main menu on the left, so feel free to explore. +* item 1 ++ item 2 +- item 3 + We've also included a reference section so you can easily find information about all the most common APIs used in game development. > **Note:** Creating games on the web draws on a number of core web technologies such as HTML, CSS, and JavaScript. The [Learning Area](/en-US/docs/Learn) is a good place to go to get started with the basics. -## Port native games to the Web +## Port native games to the Web If you are a native developer (for example writing games in C++), and you are interested in how you can port your games over to the Web, you should learn more about our [Emscripten](https://emscripten.org/index.html) tool — this is an LLVM to JavaScript compiler, which takes LLVM bytecode (e.g. generated from C/C++ using Clang, or from another language) and compiles that into [asm.js](/en-US/docs/Games/Tools/asm.js), which can be run on the Web. From 602f68f2b9b12aabc82490816a0d9db22412e51b Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Fri, 28 Jul 2023 17:53:35 +0530 Subject: [PATCH 04/14] need a token with write permission --- .github/workflows/pr-review-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 9de32c85d9c45e7..6470af5edc367e9 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -71,7 +71,7 @@ jobs: - name: Suggest changes using diff env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ inputs.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | TMPFILE=$(mktemp) git diff >"${TMPFILE}" @@ -85,7 +85,7 @@ jobs: - name: Add reviews for markdonwlint errors if: env.MD_LINT_STATUS == '1' env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ inputs.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | echo "${{ env.MD_LINT_LOG }}" | \ reviewdog \ From ded39e226eaba569a06a288c5034017be4b784b3 Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Sat, 29 Jul 2023 09:37:13 +0530 Subject: [PATCH 05/14] add permissions --- .github/workflows/pr-review-lint.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 6470af5edc367e9..00250192603ac5f 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -8,6 +8,10 @@ on: - .nvmrc - "**/*.md" +permissions: + contents: read + pull-requests: write + jobs: lint-docs: runs-on: ubuntu-latest From b14c09f5ae0b5b33662551661d4ae2206351389f Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Sat, 29 Jul 2023 09:41:53 +0530 Subject: [PATCH 06/14] grant all the permissions --- .github/workflows/pr-review-lint.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 00250192603ac5f..cd1ee03877fd4c4 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -8,9 +8,7 @@ on: - .nvmrc - "**/*.md" -permissions: - contents: read - pull-requests: write +permissions: write-all jobs: lint-docs: From 4bf39b7f3057293eccc97f9b6c36bc3842f05f2b Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 14:00:42 +0530 Subject: [PATCH 07/14] use random EOF delimiter and remove problem matcher --- .../markdownlint-problem-matcher.json | 18 ------------------ .github/workflows/pr-review-lint.yml | 9 ++++++--- 2 files changed, 6 insertions(+), 21 deletions(-) delete mode 100644 .github/workflows/markdownlint-problem-matcher.json diff --git a/.github/workflows/markdownlint-problem-matcher.json b/.github/workflows/markdownlint-problem-matcher.json deleted file mode 100644 index b85d4a963898039..000000000000000 --- a/.github/workflows/markdownlint-problem-matcher.json +++ /dev/null @@ -1,18 +0,0 @@ -{ - "problemMatcher": [ - { - "owner": "markdownlint", - "severity": "warning", - "pattern": [ - { - "regexp": "^([^:]*):(\\d+):?(\\d+)?\\s([\\w-\\/]*)\\s(.*)$", - "file": 1, - "line": 2, - "column": 3, - "code": 4, - "message": 5 - } - ] - } - ] -} diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index cd1ee03877fd4c4..42b1c2f4ae32e0f 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -45,12 +45,15 @@ jobs: - name: Lint and format markdown files run: | - #echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json" + # Generate random delimiter + # https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings + EOF="$(openssl rand -hex 8)" + echo "Running markdownlint --fix" files_to_lint="${{ env.DIFF_DOCUMENTS }}" MD_LINT_STATUS=0 MD_LINT_LOG=$(yarn markdownlint-cli2 --fix ${files_to_lint} 2>&1) || MD_LINT_STATUS=1 - echo "MD_LINT_LOG<> $GITHUB_ENV + echo "MD_LINT_LOG<<${EOF}" >> $GITHUB_ENV echo "${MD_LINT_LOG}" >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV echo "MD_LINT_STATUS=${MD_LINT_STATUS}" >> $GITHUB_ENV @@ -58,7 +61,7 @@ jobs: echo "Linting front-matter" FM_LINT_STATUS=0 FM_LINT_LOG=$(node scripts/front-matter_linter.js --fix true ${files_to_lint} 2>&1) || FM_LINT_STATUS=1 - echo "FM_LINT_LOG<> $GITHUB_ENV + echo "FM_LINT_LOG<<${EOF}" >> $GITHUB_ENV echo "${FM_LINT_LOG}" >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV echo "FM_LINT_STATUS=${FM_LINT_STATUS}" >> $GITHUB_ENV From ec457b40eba3fed474be90fd5ce765585a32e27e Mon Sep 17 00:00:00 2001 From: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 14:03:41 +0530 Subject: [PATCH 08/14] Update .github/workflows/pr-review-lint.yml Co-authored-by: A1lo --- .github/workflows/pr-review-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 42b1c2f4ae32e0f..af858c748d8f8b2 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -55,7 +55,7 @@ jobs: MD_LINT_LOG=$(yarn markdownlint-cli2 --fix ${files_to_lint} 2>&1) || MD_LINT_STATUS=1 echo "MD_LINT_LOG<<${EOF}" >> $GITHUB_ENV echo "${MD_LINT_LOG}" >> $GITHUB_ENV - echo "EOF" >> $GITHUB_ENV + echo "${EOF}" >> $GITHUB_ENV echo "MD_LINT_STATUS=${MD_LINT_STATUS}" >> $GITHUB_ENV echo "Linting front-matter" From aa8689c833a55fd2726d1e37347bdec439c01b78 Mon Sep 17 00:00:00 2001 From: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 14:04:16 +0530 Subject: [PATCH 09/14] Update .github/workflows/pr-review-lint.yml --- .github/workflows/pr-review-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index af858c748d8f8b2..74a007303764b02 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -63,7 +63,7 @@ jobs: FM_LINT_LOG=$(node scripts/front-matter_linter.js --fix true ${files_to_lint} 2>&1) || FM_LINT_STATUS=1 echo "FM_LINT_LOG<<${EOF}" >> $GITHUB_ENV echo "${FM_LINT_LOG}" >> $GITHUB_ENV - echo "EOF" >> $GITHUB_ENV + echo "${EOF}" >> $GITHUB_ENV echo "FM_LINT_STATUS=${FM_LINT_STATUS}" >> $GITHUB_ENV echo "Running Prettier" From fdd37942a2eec0e640df1c696ac4d6790e0b4647 Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 14:08:57 +0530 Subject: [PATCH 10/14] remove existing reviewdog.yml --- .github/workflows/reviewdog.yml | 45 --------------------------------- 1 file changed, 45 deletions(-) delete mode 100644 .github/workflows/reviewdog.yml diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml deleted file mode 100644 index 731b9cbc21ff765..000000000000000 --- a/.github/workflows/reviewdog.yml +++ /dev/null @@ -1,45 +0,0 @@ -name: reviewdog - -on: - - pull_request - -jobs: - prettier: - # do not run on forks - if: github.repository == 'mdn/content' - name: prettier - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - - name: Get changed files - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - BASE_SHA: ${{ github.event.pull_request.base.sha }} - HEAD_SHA: ${{ github.event.pull_request.head.sha }} - run: | - # Use the GitHub API to get the list of changed files - # documenation: https://docs.github.com/rest/commits/commits#compare-two-commits - DIFF_DOCUMENTS=$(gh api repos/{owner}/{repo}/compare/${{ env.BASE_SHA }}...${{ env.HEAD_SHA }} --jq '.files | .[] | select(.status|IN("added", "modified", "renamed", "copied", "changed")) | .filename' | xargs) - echo "DIFF_DOCUMENTS=${DIFF_DOCUMENTS}" >> $GITHUB_ENV - - - name: Setup Node.js environment - uses: actions/setup-node@v3 - with: - node-version-file: ".nvmrc" - cache: yarn - - - name: Install all yarn packages - run: yarn --frozen-lockfile - env: - # https://github.com/microsoft/vscode-ripgrep#github-api-limit-note - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - - name: Perform linting - run: yarn prettier --ignore-unknown --write ${{ env.DIFF_DOCUMENTS }} - - - name: Submit suggestion - uses: reviewdog/action-suggester@v1 - with: - github_token: ${{ secrets.GITHUB_TOKEN }} - tool_name: prettier From ef19e6bc80072c226e3690d7115b2d90877eed3f Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 15:39:35 +0530 Subject: [PATCH 11/14] fail the workflow till there are lint issues --- .github/workflows/pr-review-lint.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 74a007303764b02..d10b8a19990963d 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -69,6 +69,10 @@ jobs: echo "Running Prettier" yarn prettier -w ${files_to_lint} + if [[ -n $(git diff) || "${MD_LINT_STATUS}" == "1" || "${FM_LINT_STATUS}" == "1" ]]; then + echo "CHANGES_REQUIRED=true" >> $GITHUB_ENV + fi + - name: Setup reviewdog uses: reviewdog/action-setup@v1 with: @@ -105,3 +109,9 @@ jobs: run: | echo "${{ env.FM_LINT_LOG }}" exit 1 + + - name: Fail till changes are pending + if: env.CHANGES_REQUIRED == 'true' + run: | + echo "Please fix all the linting issues suggested in the review comments." + exit 1 From 74650b6b55703679f11f17ae63b3fe3dc690502a Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 15:44:58 +0530 Subject: [PATCH 12/14] update the token --- .github/workflows/pr-review-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index d10b8a19990963d..714ab881ece5068 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -80,7 +80,7 @@ jobs: - name: Suggest changes using diff env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.PR_REVIEW_PAT }} run: | TMPFILE=$(mktemp) git diff >"${TMPFILE}" @@ -94,7 +94,7 @@ jobs: - name: Add reviews for markdonwlint errors if: env.MD_LINT_STATUS == '1' env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.PR_REVIEW_PAT }} run: | echo "${{ env.MD_LINT_LOG }}" | \ reviewdog \ From d67c910355f362081a11d96b63d06d52f25753eb Mon Sep 17 00:00:00 2001 From: OnkarRuikar <87750369+OnkarRuikar@users.noreply.github.com> Date: Tue, 1 Aug 2023 18:12:12 +0530 Subject: [PATCH 13/14] Check the new token --- .github/workflows/pr-review-lint.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 714ab881ece5068..4fc372a34ae0217 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -73,6 +73,17 @@ jobs: echo "CHANGES_REQUIRED=true" >> $GITHUB_ENV fi + - name: check available tokens + run: | + echo GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }} + echo REVIEW_TOKEN=${{ secrets.PR_REVIEW_PAT }} + cat < Date: Tue, 1 Aug 2023 18:20:37 +0530 Subject: [PATCH 14/14] Retrigger workflow --- .github/workflows/pr-review-lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/pr-review-lint.yml b/.github/workflows/pr-review-lint.yml index 4fc372a34ae0217..da18753f0198c99 100644 --- a/.github/workflows/pr-review-lint.yml +++ b/.github/workflows/pr-review-lint.yml @@ -83,6 +83,9 @@ jobs: cat <