Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for PermissionStatus.name #10705

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Add documentation for PermissionStatus.name #10705

merged 3 commits into from
Nov 22, 2021

Conversation

bershanskiy
Copy link
Contributor

@bershanskiy bershanskiy commented Nov 22, 2021

Summary

Add documentation for PermissionStatus.name.

Motivation

Keep MDN up-to-date.

Supporting details

This feature is already supported in Firefox and tracked by BCD (entry), will be supported by Chrome 97 (ChromeStatus entry). Spec link.

Related issues

BCD was updated with this info in mdn/browser-compat-data#13466

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@bershanskiy bershanskiy requested a review from a team as a code owner November 22, 2021 23:05
@bershanskiy bershanskiy requested review from jpmedley and removed request for a team November 22, 2021 23:05
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PermissionStatus/name
Title: PermissionStatus.name
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.PermissionStatus.name

External URLs

URL: /en-US/docs/Web/API/PermissionStatus
Title: PermissionStatus
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/PermissionStatus/name
Title: PermissionStatus.name
on GitHub

No new external URLs

(this comment was updated 2021-11-22 23:58:23.463325)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @bershanskiy ,

The way we do "syntax" sections for properties changed recently - now we just have information about the value. I made the required change. I did also consider copying in the information.

@hamishwillee hamishwillee merged commit 89ab518 into mdn:main Nov 22, 2021
@bershanskiy bershanskiy deleted the PermissionStatus.name branch November 23, 2021 00:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants