Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Fonts example code not matching description #37243

Open
matthewlst opened this issue Dec 17, 2024 · 2 comments · May be fixed by #37258
Open

Variable Fonts example code not matching description #37243

matthewlst opened this issue Dec 17, 2024 · 2 comments · May be fixed by #37258
Labels
Content:CSS Cascading Style Sheets docs

Comments

@matthewlst
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_fonts/Variable_fonts_guide

What specific section or headline is this issue about?

"Example for a standard upright (Roman) font" and "Example for a font that contains only italics and no upright characters"

What information was incorrect, unhelpful, or incomplete?

Each of these sections provides a sample @font-face definition and a description. The descriptions discuss oblique 0deg and oblique 14deg values, but I didn't see any such value in the sample code.

What did you expect to see?

If the example is correct as-is (e.g., the oblique values are implied), the wording could be improved to clarify. Otherwise, the code block could be updated to add some code related to oblique, or the description altered to remove such references.

Do you have any supporting links, references, or citations?

It seems the descriptions were added in 796096b without a change to the code.

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@matthewlst matthewlst added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 17, 2024
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 17, 2024
@matthewlst matthewlst changed the title Desctiption not Variable Fonts example code not matching description Dec 17, 2024
@Josh-Cena
Copy link
Member

@OnkarRuikar

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 17, 2024
@OnkarRuikar OnkarRuikar linked a pull request Dec 18, 2024 that will close this issue
@OnkarRuikar
Copy link
Contributor

The example is correct as-is. We meant to imply font-style: oblique 0deg and font-style: oblique 0deg 20deg are equivalent to font-style: normal. Submitted a PR to rephrase the sentences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants