Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of new dialog light dismiss behaviors #37196

Open
mfreed7 opened this issue Dec 13, 2024 · 2 comments
Open

Add documentation of new dialog light dismiss behaviors #37196

mfreed7 opened this issue Dec 13, 2024 · 2 comments
Labels
Content:HTML Hypertext Markup Language docs effort: medium This task is a medium effort. waiting for implementations Waiting for feature to be implemented in browsers

Comments

@mfreed7
Copy link

mfreed7 commented Dec 13, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

There are new dialog behaviors, proposed here:

whatwg/html#10737

Specifically, a closedby attribute can be used to enable "light dismiss" behaviors for <dialog>, akin to popovers. Also, a new dialog.requestClose() method allows a programmatic request to close the dialog, which goes through the cancel/close process.

What did you expect to see?

Documentation

Do you have any supporting links, references, or citations?

whatwg/html#10737

Do you have anything more you want to share?

I'm hoping to ship this in Chrome M134, pending approvals, etc.

@mfreed7 mfreed7 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 13, 2024
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Dec 13, 2024
@hamishwillee
Copy link
Collaborator

@mfreed7 Thanks for this. MDN doesn't document things until there is an implementation, and from those linked bugs there isn't one yet right?

FWIW I'd like to do this - spent some time on popovers/dialogs recently so its in my head.

@hamishwillee hamishwillee added effort: medium This task is a medium effort. waiting for implementations Waiting for feature to be implemented in browsers and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 13, 2024
@mfreed7
Copy link
Author

mfreed7 commented Dec 13, 2024

@mfreed7 Thanks for this. MDN doesn't document things until there is an implementation, and from those linked bugs there isn't one yet right?

Not yet. This is somewhat chicken-and-egg, since the WHATWG process requires that an MDN issue be filed before the new spec can land (see the second-to-last checkbox on whatwg/html#10737). And at least Chromium's shipping process generally wants a landed spec before shipping. So MDN has to come first.

FWIW I'd like to do this - spent some time on popovers/dialogs recently so its in my head.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs effort: medium This task is a medium effort. waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Development

No branches or pull requests

2 participants