Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update kumascript related to secureContext #37108

Closed
3 tasks done
ohprettyhak opened this issue Nov 25, 2024 · 4 comments · Fixed by mdn/yari#12183 or #37111
Closed
3 tasks done

[ko] Update kumascript related to secureContext #37108

ohprettyhak opened this issue Nov 25, 2024 · 4 comments · Fixed by mdn/yari#12183 or #37111
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@ohprettyhak
Copy link
Contributor

ohprettyhak commented Nov 25, 2024

Summary

Many documents use secureContext_header and secureContext_inline, but they have not been translated into Korean.

URL

https://developer.mozilla.org/ko/docs/Web/API/PushSubscription (secureContext_header)
https://developer.mozilla.org/ko/docs/Web/API/Clipboard_API (secureContext_inline)

Reproduction steps

  1. Navigate any Korean-translated documents using a security context header or badge.

Expected behavior

The text related to the security context should be shown in Korean.

For Header: 이 기능은 일부 또는 모든 지원 브라우저의 보안 컨텍스트 (HTTPS)에서만 사용할 수 있습니다.
For Badge: 이 기능은 보안 컨텍스트 (HTTPS)에서만 사용할 수 있습니다

Actual behavior

Currently, the text related to the security context is shown in English.

For Header: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers.
For Badge: This feature is available only in secure contexts (HTTPS)

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

1) header

image

2) badge

image

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 25, 2024
@ohprettyhak ohprettyhak changed the title [ko] Update documentation related to secureContext [ko] Update kumascript related to secureContext Nov 26, 2024
@argl
Copy link
Contributor

argl commented Dec 5, 2024

This is a missing translation in the content repository (see

"secure_context_label": {
), transferring the issue.

@argl argl removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 5, 2024
@argl argl transferred this issue from mdn/yari Dec 5, 2024
@github-actions github-actions bot added Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Dec 5, 2024
@ohprettyhak
Copy link
Contributor Author

@argl If the L10n-Template.json file is updated, should I understand that Yari's KumaScript gets automatically updated as well?

@argl
Copy link
Contributor

argl commented Dec 5, 2024

This comes at an unfortunate point in time, since we are in the process of changing out a huge part of our rendering pipeline from yari to the new rari system. The new rari code uses the json file mentioned above, the deprecated yari code uses kumascript/secureContext_header.ejs. I would opt to go with the future implementation, thats is why I transferred this ticket to content. Content is also where those translations ultimately should be managed, that is the reason for the change.

I expect rari to be rolled out before the end of the year.

@ohprettyhak
Copy link
Contributor Author

This comes at an unfortunate point in time, since we are in the process of changing out a huge part of our rendering pipeline from yari to the new rari system. The new rari code uses the json file mentioned above, the deprecated yari code uses kumascript/secureContext_header.ejs. I would opt to go with the future implementation, thats is why I transferred this ticket to content. Content is also where those translations ultimately should be managed, that is the reason for the change.

I expect rari to be rolled out before the end of the year.

Thank you for the explanation. I will add the translations to the JSON file and submit a new Merge Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
2 participants