Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpeechSynthesisEvent.elapsedTime spec change ms to s #13236

Merged
merged 1 commit into from
Nov 16, 2021
Merged

SpeechSynthesisEvent.elapsedTime spec change ms to s #13236

merged 1 commit into from
Nov 16, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Nov 2, 2021 •
edited
Loading

The Web Speech API spec recently changed the event property SpeechSynthesisEvent.elapsedTime from milliseconds to seconds:

There is a demo fiddle here https://jsfiddle.net/ybe1c6ot/ (comes from this issue).

To update this I have followed @ddbeck suggestion of having a subfeature for the deprecated behaviour named milliseconds, which has a version-removed matching the version in which browsers update. I also will not update the handlers and specific instances.

I also set the experimental flag false.

P.S.- Docs tracking: mdn/content#10221

Fixes #12595

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 2, 2021
This was referenced Nov 2, 2021
Closed
Closed
@hamishwillee
Copy link
Collaborator Author

Note: Update to be deprecated subfeature - milliseconds. Just in the Event.

ddbeck
ddbeck requested changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little fixes. Thank you!

api/SpeechSynthesisEvent.json Show resolved Hide resolved
api/SpeechSynthesisEvent.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@hamishwillee @ddbeck
SpeechSynthesisEvent.elapsedTime subfeature - milliseconds
4ddc0e1 
Update api/SpeechSynthesisEvent.json

Co-authored-by: Daniel D. Beck <[email protected]>
@hamishwillee
Copy link
Collaborator Author

Thanks @ddbeck - makes sense. Should be good to merge now. FYI I squashed my own commits, just because I felt like hiding the screw up with adding yarn.lock :-0

This was referenced Nov 12, 2021
Closed
Merged
ddbeck
ddbeck approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit dfab3e9 into mdn:main Nov 16, 2021
@ddbeck ddbeck mentioned this pull request Nov 17, 2021
Closed
This was referenced Nov 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makotokato makotokato makotokato left review comments

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "SpeechSynthesisUtterance.onend": wrong unit for elapsedTime
3 participants
@hamishwillee @ddbeck @makotokato