Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial data for Deno #10753

Merged
merged 43 commits into from
Aug 17, 2021
Merged

Add initial data for Deno #10753

merged 43 commits into from
Aug 17, 2021

Conversation

lucacasonato
Copy link
Collaborator

@lucacasonato lucacasonato commented Jun 3, 2021

Summary

This PR adds BDC data for the Deno runtime. It adds versioned support data for all currently supported APIs and JS features, and negative support status to APIs which are either on the horizon for us, or likely for users to expect in Deno, or both.

Test results and supporting details

As per "Addition of browsers" section in the data guidelines, see the proposal here: #5476 (comment)

Data is primarily based on my first hand knowledge of the platform, but all cross-referenced using the last 11 minor releases + our WPT data at https://wpt.deno.land.

Related issues

Closes #5476

@lucacasonato lucacasonato requested a review from ddbeck as a code owner June 3, 2021 23:21
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 3, 2021
@queengooborg queengooborg added bulk_update An update to a mass amount of data, or scripts/linters related to such changes data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Jun 4, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 4, 2021
@foolip
Copy link
Collaborator

foolip commented Jun 5, 2021

If you haven't seen it yet, you might want to check out https://mdn-bcd-collector.appspot.com/ which has generated tests for a lot of BCD. It would need some tweaking to work with Deno, but then you could verify a lot of this data, and most likely find many errors.

@lucacasonato
Copy link
Collaborator Author

@foolip Oh very nice. Is there a DOM free version of that? (JS only, with programmatic output?)

@foolip
Copy link
Collaborator

foolip commented Jun 7, 2021

There isn't, but I'm thinking it shouldn't be a huge undertaking. All the tests are already in a generated tests.json and generating a big single script with all the feature detects from there shouldn't be too hard...

@lucacasonato
Copy link
Collaborator Author

WPT data is now also available on wpt.fyi: https://staging.wpt.fyi/results/?product=deno

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience while I reviewed this, @lucacasonato!

I've gotten through the api/ section today. I'm trusting that your data is correct, but I looked for structural and style issues. I caught a few things of interest and I'll try to return to the javascript data soon (though feel free to make changes implied by my existing comments, if there's anything you'd already recognize).

api/Console.json Outdated Show resolved Hide resolved
api/Console.json Outdated Show resolved Hide resolved
api/Console.json Outdated Show resolved Hide resolved
api/Console.json Outdated Show resolved Hide resolved
api/Console.json Outdated Show resolved Hide resolved
api/ReadableStreamDefaultController.json Outdated Show resolved Hide resolved
api/ReadableStreamDefaultReader.json Outdated Show resolved Hide resolved
api/Request.json Outdated Show resolved Hide resolved
api/TextDecoder.json Outdated Show resolved Hide resolved
api/TransformStreamDefaultController.json Outdated Show resolved Hide resolved
@lucacasonato
Copy link
Collaborator Author

No problem. Have a nice week off! 🏖

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny things to address. Thank you!

api/SubtleCrypto.json Outdated Show resolved Hide resolved
browsers/deno.json Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your care and patience with this, @lucacasonato. I'm pleased to approve this and I'll be merging momentarily. These changes will be included in v4.0.0, which I aim to ship later in the week.

With that, let me be the first to say: welcome to BCD, Deno! 🎉

@ddbeck ddbeck merged commit a371e85 into mdn:main Aug 17, 2021
@lucacasonato lucacasonato deleted the deno branch August 17, 2021 16:44
@lucacasonato
Copy link
Collaborator Author

Thanks Daniel!

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Aug 17, 2021
ddbeck added a commit that referenced this pull request Aug 19, 2021
* Bump version to v4.0.0

* Add release note for #11234

* Bump known issues

* Add release note for #11760

* Add release note for #11286

* Add release note for #9830

* Add release note for #10334

* Add v4.0.0 highlights to release notes

* Add release note for #10753

* Revise description of `accepts_flags` hint

* Add release note for #11961

* Add release note for #12059

* Add stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new engine/platform Deno
5 participants