-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial data for Deno #10753
Add initial data for Deno #10753
Conversation
If you haven't seen it yet, you might want to check out https://mdn-bcd-collector.appspot.com/ which has generated tests for a lot of BCD. It would need some tweaking to work with Deno, but then you could verify a lot of this data, and most likely find many errors. |
@foolip Oh very nice. Is there a DOM free version of that? (JS only, with programmatic output?) |
There isn't, but I'm thinking it shouldn't be a huge undertaking. All the tests are already in a generated tests.json and generating a big single script with all the feature detects from there shouldn't be too hard... |
WPT data is now also available on wpt.fyi: https://staging.wpt.fyi/results/?product=deno |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience while I reviewed this, @lucacasonato!
I've gotten through the api/
section today. I'm trusting that your data is correct, but I looked for structural and style issues. I caught a few things of interest and I'll try to return to the javascript data soon (though feel free to make changes implied by my existing comments, if there's anything you'd already recognize).
Co-authored-by: Daniel D. Beck <[email protected]>
No problem. Have a nice week off! 🏖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny things to address. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your care and patience with this, @lucacasonato. I'm pleased to approve this and I'll be merging momentarily. These changes will be included in v4.0.0, which I aim to ship later in the week.
With that, let me be the first to say: welcome to BCD, Deno! 🎉
Thanks Daniel! |
* Bump version to v4.0.0 * Add release note for #11234 * Bump known issues * Add release note for #11760 * Add release note for #11286 * Add release note for #9830 * Add release note for #10334 * Add v4.0.0 highlights to release notes * Add release note for #10753 * Revise description of `accepts_flags` hint * Add release note for #11961 * Add release note for #12059 * Add stats
Summary
This PR adds BDC data for the Deno runtime. It adds versioned support data for all currently supported APIs and JS features, and negative support status to APIs which are either on the horizon for us, or likely for users to expect in Deno, or both.
Test results and supporting details
As per "Addition of browsers" section in the data guidelines, see the proposal here: #5476 (comment)
Data is primarily based on my first hand knowledge of the platform, but all cross-referenced using the last 11 minor releases + our WPT data at https://wpt.deno.land.
Related issues
Closes #5476